Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor other binary operations over span types to match __add__. #102

Open
6 tasks
frreiss opened this issue Aug 28, 2020 · 0 comments
Open
6 tasks

Refactor other binary operations over span types to match __add__. #102

frreiss opened this issue Aug 28, 2020 · 0 comments

Comments

@frreiss
Copy link
Member

frreiss commented Aug 28, 2020

PR #98 refactored the binary add operation of all the span types (Span, TokenSpan, SpanArray, TokenSpanArray) into a single function add_spans() (located in text_extensions_for_pandas/array/span_util.py) that handles all combinations of the four types in either argument.

Other binary operations should be refactored into the same structure. Here's a list:

  • __lt__()
  • __le__()
  • __gt__()
  • __ge__()
  • __eq__()
  • overlaps()

Note: The above list may not be complete. Please edit this description to add any missing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant