Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reroute_ts() to be less error-prone. #30

Open
frreiss opened this issue Feb 27, 2019 · 0 comments
Open

Refactor reroute_ts() to be less error-prone. #30

frreiss opened this issue Feb 27, 2019 · 0 comments

Comments

@frreiss
Copy link
Member

frreiss commented Feb 27, 2019

Every time that I've used the reroute_ts() function in reroute.py, I've ended up putting the arguments in the wrong order. Mixing up the ts0 and ts1 args to this function doesn't generally lead to errors, but to an incorrect modification of the graph that in turn leads to strange problems downstream in the user's code. We should update the documentation, the API, and the error-handling to make this kind of coding error less likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant