Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link list repeats a node and builds wrong network #803

Open
ikb6 opened this issue Apr 24, 2024 · 4 comments
Open

Link list repeats a node and builds wrong network #803

ikb6 opened this issue Apr 24, 2024 · 4 comments
Assignees
Labels
[issue-type] bug Something isn't working

Comments

@ikb6
Copy link
Collaborator

ikb6 commented Apr 24, 2024

This bug was emailed to me by a user. I got on a call with him, copy pasted the cells into a blank csv, saved and used it. That seemed to fix it then, but he tried doing it and that fix is not working for him. Could you check the CSV file at link below and see what could be corrupted?

Trouble sharing link- please see email for attachments

https://cdc.sharepoint.com/:x:/r/teams/nchhstp-dhap-lb-microbetrace/Shared%20Documents/General/Files%20for%20bug%20reports/Issue803_microbetrace_link_test_Nelson.csv?d=wbc45579b6b97477994810c2262cd8813&csf=1&web=1&e=HuHLqf

Wrong network

Neslson_test_link_bug.JPG

Correct network after copy pasting
Nelson_correct_network.JPG

@ikb6 ikb6 added the [issue-type] bug Something isn't working label Apr 24, 2024
@dacowan404
Copy link
Collaborator

The csv file that you sent has a space before all the values in the target column. So MicrobeTrace is interpreting "AC001" and " AC001" as different node names. In the short term, he could trim function in excel to get rid of these whitespaces. When I did that I got the correct network except link be AB001 and AC003 which isn't in CSV. This is probably just a typo because link between AB001 and AC001 is in the CSV twice.
I thought MicrobeTrace had this functionality to remove whitespace at start and end.

@billswitzer2
Copy link
Collaborator

billswitzer2 commented Apr 25, 2024 via email

@ikb6
Copy link
Collaborator Author

ikb6 commented Apr 25, 2024

Ah, great catch, thanks David!

@dacowan404
Copy link
Collaborator

@ikb6 I have updated the angular version to trim whitespaces from node names. It is currently deployed on the mossy site, so you should be able to use the original file that was causing this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[issue-type] bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants