Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCV dummy dataset- MT PROD uses the wrong distance field to launch network #797

Open
ikb6 opened this issue Apr 10, 2024 · 2 comments
Open
Assignees
Labels
high-priority [issue-type] bug Something isn't working

Comments

@ikb6
Copy link
Collaborator

ikb6 commented Apr 10, 2024

threshold_links_YSmodified.xlsx
When I load 2 HCV dummy files (a node list and a distance edgelist- see attached file), I want MT to use the field min_dist for distance threshold. I load files, select 'min_dist' from drop down, set TN93 to 0.052 (that's their cut-off) and launch. But I get a hairball.
When I go to Settings and check, I realize that the links are being filtered on 'distance' field (I think MT automatically assigns this field?) rather than on min-dist like I asked it to.
When I select min-dist from the drop down menu in Settings, it gives the network that it is supposed to.

Can you check why MT would not use min-dist to begin with even though it is specified at loading? See video with console log below

https://cdc.sharepoint.com/:v:/r/teams/nchhstp-dhap-lb-microbetrace/Shared%20Documents/General/Files%20for%20bug%20reports/Angular_dist_miniHistogram_ZenhubIssue748.mp4?csf=1&web=1&e=gUXxKP

@ikb6 ikb6 added [issue-type] bug Something isn't working high-priority labels Apr 10, 2024
@dacowan404 dacowan404 self-assigned this Apr 10, 2024
@dacowan404
Copy link
Collaborator

The problem is that when if you specify distance field for link file, MicrobeTrace expects that column named to be 'distance'. If you specify that field with a different name, it records the distance as being 0. So, to fix this bug, you just need to change the name of that column in your excel file. I have found a way to fix this in the code so that field can be named something else, but I need to test it more first.

dacowan404 added a commit to mossy426/MicrobeTrace that referenced this issue Apr 15, 2024
@dacowan404
Copy link
Collaborator

I have committed and deployed the update to Mossy url so now columns (besides just those named 'distance') can be used to set the distance when loading an edge list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority [issue-type] bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants