Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Node/Link color tables appear/disappear in different views #788

Open
roxycintron opened this issue Mar 1, 2024 · 1 comment
Open
Assignees
Labels
[issue-type] bug Something isn't working

Comments

@roxycintron
Copy link
Collaborator

When a new view is selected, the node color table appears in the new view. If you go back to the 2D network view, the link color table disappears. If you close the node color table and open a new view, it appears again in the opened views.

To Reproduce

  1. Select "Continue with Sample Dataset" in the Angular launch page. The network renders correctly. Note the node and link color tables.
    image

  2. Select 'Table' (or any of the other views) and see the node color table.
    image

  3. Go back to the 2D network view and see that the link color table is missing.
    image

  4. Close the node color table in any of the views and select another view tab or open a new view. The node color table appears again.

  5. Go to 'Settings' and select to show link color table but it will not show up.
    image

Expected behavior

  • The link color table should appear in the 2D network after changing views unless the user closes it.
  • If user closes a color table, it shouldn't appear in any of the views unless the user selects to show the color table again.
  • Color tables are more useful for 2D network, map and phylogenetic tree views. It's ok if they show up automatically in those views. If user closes them, they shouldn't reappear.
  • Can we code for color tables to do not appear in table and alignment views?
@dacowan404
Copy link
Collaborator

Fixed bug that caused link table to not reappear in some situations. Also node color table and link color table automatically show and hide based on view selected and value of color node/links by.
Currently, if a user hides a table in 2D Network then clicks another view where the table is presents (such as going from 2D -> map, going from 2D -> table -> 2D) then the table reappears. May want to change this in the future.

dacowan404 added a commit to mossy426/MicrobeTrace that referenced this issue May 10, 2024
…r/disappear based on current view and color node/link by settings. Zenhub issues CDCgov#805 and CDCgov#788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[issue-type] bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants