Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better way/method can be implemented to display the applied filter info. #115

Open
Akshatji800 opened this issue Dec 11, 2022 · 23 comments
Assignees
Labels
enhancement New feature or request good-to-go Available to work on/ Good to go issue

Comments

@Akshatji800
Copy link
Member

Is your feature request related to a problem? Please describe.
The current way of displaying the applied filter info in the search bar can be improved/changed to make it look better.

Describe the solution you'd like
To be proposed by the contributors who want to take up the issue by commenting on the issue.

@Akshatji800 Akshatji800 added enhancement New feature or request good-to-go Available to work on/ Good to go issue labels Dec 11, 2022
@sainideepanshu199
Copy link

please assign this issue to me.

@Akshatji800
Copy link
Member Author

Sure @sainideepanshu199 I am assigning you this issue. You can start by proposing the new suggested design and once the design gets approved then you can start coding/implementing it.

@sainideepanshu199
Copy link

I have installed Flood and qBittorrent but I am getting this error after following the contributing.md guide.
image

@Akshatji800
Copy link
Member Author

I have installed Flood and qBittorrent but I am getting this error after following the contributing.md guide. image

@sainideepanshu199 there is some issue with qBittorent and flood which needs to be addressed and resolved until then you can use transmission instead of qBittorent. The setup is almost similar.

@Akshatji800
Copy link
Member Author

@sainideepanshu199 is there any progress on this issue?

Also @sainideepanshu199 were you able to solve the issue you were facing while setting up the project? If not then this is what you need to do to resolve the issue.

Uninstall the older version of flood u have by using the command sudo npm uninstall -g flood and install the latest but not released version by using the command sudo npm i -g @jesec/flood

@sainideepanshu199
Copy link

i am very sorry for no work on this issue, due to some serious problems couldn't work on anything.
but now i have started the setup again and i get a new issue while accessing app after opening web client from transmission app.
image

could u please resolve this problem

@amitamrutiya
Copy link
Contributor

For solve this error, while installing you have to install this Web Interface Option.

image

@sainideepanshu199
Copy link

can someone help me resolve this issue now, even after entering correct authentication details it shows failed login
image

@amitamrutiya
Copy link
Contributor

amitamrutiya commented Jan 19, 2023

You have to enter a details that you use to create flood web-ui account. If it give this login error then try to uninstall flood using sudo npm uninstall -g flood and again try to install sudo npm i -g @jesec/flood and create new account. after create new flood account try to login with that details.
I think this error comes because you enter wrong user details .

@Akshatji800
Copy link
Member Author

Unassigning this issue to @sainideepanshu199 as there was no progress reported on the issue

@Akshatji800 Akshatji800 pinned this issue Mar 5, 2023
@Akshatji800 Akshatji800 unpinned this issue Mar 5, 2023
@Ronakkkkk
Copy link

Can you assign me this issue.

@Akshatji800
Copy link
Member Author

Can you assign me this issue.

Hello @Ronakkkkk please let me know if you still want to work on this issue - if yes then I will assign this issue to you.

@tb-rules10
Copy link

Please assign this issue to me.

@Akshatji800
Copy link
Member Author

Please assign this issue to me.

Please let me know what is your idea and how you are gonna improve it before I assign this issue to you.

@tb-rules10
Copy link

tb-rules10 commented Sep 27, 2023

I am thinking of combining Filters and Sort into a single bottom sheet and selected filters and sort by status can be seen below the search bar like this:-

image

@Akshatji800
Copy link
Member Author

I am thinking of combining Filters and Sort into a single bottom sheet and selected filters and sort by status can be seen below the search bar like this:-

image

Hey @tb-rules10, thanks for proposing this but the reason why this was not followed and approved initially itself is that we want to save as much space as we can on the main screen to show torrents. This is the reason why search bar, download speed etc are hidden and appears on top swipe. Please suggest something that aligns with our minimal screen space usage goal.

@Nailsonseat
Copy link

Nailsonseat commented Mar 4, 2024

Hi @Akshatji800 its Aadarsh from FOSS 24. I think we can use chips to better portray the filtering options instead of the current radio selector. This proposal is also in line with using minimum space possible, since a user would have to scroll less.

Below is a skeleton of what the filter would look like, as the tracker list would be varying in size, the filter dialog will be scroll-able and will use wrap widget to handle devices of varying width.

flood

@Akshatji800
Copy link
Member Author

Hey @Nailsonseat assigning this issue to you. But this issue is more about how we are gonna show the current filter selected in a better way. Currently it is shown in searchbar. I want you to work on that first.

@Nailsonseat
Copy link

Hey @Nailsonseat assigning this issue to you. But this issue is more about how we are gonna show the current filter selected in a better way. Currently it is shown in searchbar. I want you to work on that first.

Thank you Akshat, I will come back to you with an idea regarding this very soon.

@Akshatji800
Copy link
Member Author

@Nailsonseat good observation but don't you think that removing filter icon and putting a dismiss button instead of it creates confusion that what actually complete is? The idea is good that there should be a way to dismiss the filter (it is definitely increasing the UX) but you need to think of a better UI.

@Nailsonseat
Copy link

Nailsonseat commented Mar 5, 2024

@Nailsonseat good observation but don't you think that removing filter icon and putting a dismiss button instead of it creates confusion that what actually complete is? The idea is good that there should be a way to dismiss the filter (it is definitely increasing the UX) but you need to think of a better UI.

Good point, the user will not know if 'complete' is a filter or something else, will work on it. I deleted the original post because I wanted to show a good way to show sorting too along with filters. I will come to you will a new idea for both soon

@Nailsonseat
Copy link

Nailsonseat commented Mar 6, 2024

@Akshatji800 I have some new mock-ups or rather old ones because these designs are more closer to the original UI.

Initial state Selected state
Flood_5 Flood_6

Filters

I have two points with respect to the concern with confusion with dismiss button

  • The current mock-up has UI which is more intuitive in terms of deducing what the "complete" and the X button stands for, IMO.
  • The filter is located on far right where there is no other button near it, so I think the case for confusion would be even lower.

Sort

  • I included the sort button in a border to make it seem more like a button but I'm not sure about it, need you input on this.
  • Dismiss button is not needed for sorting as there is always a sort type that is always selected.
  • Currently whichever sort type you select , it always displays the A-Z icon, I think we can find all the 12 icons for the 12 sort types of sorts here

Do let me know if more improvements can be made here

@Nailsonseat
Copy link

Nailsonseat commented Mar 10, 2024

i found a potential implementation for the sort button straight from the material 3 website. Just imagine this with icons, and without the text in the button. The focus is the button not the drop down itself

demo.mp4

I ll be on the lookout for better options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good-to-go Available to work on/ Good to go issue
Projects
None yet
Development

No branches or pull requests

6 participants