Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed Keys #5

Open
om3n07 opened this issue Jun 13, 2019 · 3 comments
Open

Exposed Keys #5

om3n07 opened this issue Jun 13, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@om3n07
Copy link

om3n07 commented Jun 13, 2019

There are two exposed keys in the backend folder:
https://github.com/ByronHsu/Never-Blink/blob/master/backend/server.key
https://github.com/ByronHsu/Never-Blink/blob/master/backend/server.key.org

@ByronHsu
Copy link
Owner

ByronHsu commented Jun 14, 2019

Hi @om3n07 !
I have trouble in setting socket-flask to https. After searching lots of related topics on it, I use flask-sslify to solve it but it still cause the following problems.

  1. It will raise error when client connects, but the server still works fine.
  2. Developers needs to generate their own key to set up the https server. It is a little bit troublesome.
    Did you have solutions to these problems? Thanks!

@ByronHsu ByronHsu added the help wanted Extra attention is needed label Jun 14, 2019
@no-1ne
Copy link

no-1ne commented Jun 19, 2019

Get rid of backend, using TF.js for blink detection do it client side, and for webrtc signalling there is firebase or equivalents

@conradkirschner
Copy link

Blink detection in the client side will enable cheating, you should never handle win conditions on clientside!

this whole thing is pretty pretty nice, it's 2 years old and maybe not maintained anymore... but still nice + great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants