Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSVReader state updated after file load, even if noProgressBar is true #88

Closed
stefee opened this issue Jun 8, 2021 · 2 comments · Fixed by #89 · May be fixed by #142
Closed

CSVReader state updated after file load, even if noProgressBar is true #88

stefee opened this issue Jun 8, 2021 · 2 comments · Fixed by #89 · May be fixed by #142

Comments

@stefee
Copy link
Contributor

stefee commented Jun 8, 2021

We encountered this error in our project:

Screenshot 2021-06-08 at 1 28 46 pm

We tracked down the error to the user closing a file loading modal too quickly after loading the file, because the CSVReader was updating internal state using setTimeout.

We expected that setting noProgressBar would resolve this bug since the problem was progress bar state updating after the component was unmounted.
@stefee stefee mentioned this issue Jun 8, 2021
Merged
@sophiabarclay
Copy link

sophiabarclay commented May 26, 2022 •
edited

I see the noProgressBar bar has been removed in recent versions. Is there a workaround for this warning on the latest version?

@callum-fairbairn-cazoo
Copy link

Is there any update on this?

@callumfairbairn callumfairbairn mentioned this issue Aug 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stefee @sophiabarclay @callum-fairbairn-cazoo