Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reduce noise from Librdkafka on non-fatal errors #3064

Closed
iancooper opened this issue Apr 23, 2024 · 0 comments
Closed

[Feature] Reduce noise from Librdkafka on non-fatal errors #3064

iancooper opened this issue Apr 23, 2024 · 0 comments
Assignees
Labels
3 - Done feature request v9 Required for v9 release v10 Allocal to a v10 release

Comments

@iancooper
Copy link
Member

Is your feature request related to a problem? Please describe.
Librdkafka raises both fatal and non-fatal errors to your producer/consumer. At this time we log these as an Error. This is noisy, and often relates to errors that Librdkafka is handling and we cannot intercept.

Describe the solution you'd like
When Librdkafka raises an error we should determine if it is fatal. If it is fatal, we should log as Fatal; if it is non-fatal we should log a Warning. This allows users of Brighter to decide if they want to see non-Fatal errors more easily and escalates a Fatal error, which might indicate that we have a zombie service if it does not crash.

Describe alternatives you've considered
The alternative would be to log Fatal as Error, but Librdkafka is doing a lot of error handling for us, so most Errors that are non-Fatal are coped with by Librdkafka and do not require a response.

@iancooper iancooper added 1 - Up Next feature request v10 Allocal to a v10 release v9 Required for v9 release labels Apr 23, 2024
@iancooper iancooper self-assigned this Apr 23, 2024
@iancooper iancooper changed the title [FEATURE] Reduce noise from Librdkafka on non-fatal errors [Feature] Reduce noise from Librdkafka on non-fatal errors May 6, 2024
iancooper added a commit that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done feature request v9 Required for v9 release v10 Allocal to a v10 release
Projects
None yet
Development

No branches or pull requests

1 participant