Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a NuGet package #211

Open
michael-lang opened this issue Jul 26, 2013 · 12 comments
Open

Create a NuGet package #211

michael-lang opened this issue Jul 26, 2013 · 12 comments

Comments

@michael-lang
Copy link

I would create a NuGet package build utility for this project if you would accept a pull request for it and publish to NuGet.

The publish to NuGet process would be simple each time a release is made.
0) potentially update nuspec description field (not required each build)

  1. run release.cmd
  2. login to http://NuGet.org/
  3. upload the generated nupkg file.

Here is a project showing what that addition would look like:

https://github.com/michael-lang/jquery-auto-async

files:
Release.cmd
.nuget** (2 config files, 1 exe - from Nuget.org)
NuGet\jsrender.nuspec
Build** (various standard build support files, 5 text, 1 dll; Nothing custom to project)

Note, I am updating the jquery-auto-async project to use jsRender.

@michael-lang
Copy link
Author

There is this jsRender related package on NuGet. It would be good to have a pure jsRender package however, instead of it being bundled with all of HotGlue.

http://www.nuget.org/packages/HotGlue.Template.JsRender/

@BorisMoore
Copy link
Owner

@michael-lang: Thanks michael. In principal, yes, though of course I would need take a look before deciding - and right now my priority is getting the official beta out for JsViews.

But definitely after the beta, moving to V1, I had planned anyway to add Nuget packages for both JsRender and JsViews.

So if you want to already set up a package, as a pull request, that would be great. I would need to get up to speed on Nuget, to validate the pull request before going ahead with it, So I can't promise how soon or whether I will pull in the package, but hopefully it will make sense to do so, and I will....

@BorisMoore BorisMoore changed the title Would you accept a pull request for a NuGet package build? Create a NuGet package Aug 6, 2015
@BorisMoore
Copy link
Owner

Planned for V1.

@BorisMoore
Copy link
Owner

BorisMoore commented Feb 28, 2016

@BorisMoore BorisMoore changed the title Create a NuGet package Create a NuGet package and typescript definitions Oct 12, 2017
@BorisMoore BorisMoore mentioned this issue Oct 12, 2017
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Nov 25, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue BorisMoore/jsviews#409
  Datepicker fails when convertors in use

- Issue BorisMoore/jsviews#209
  Improved support for void elements with no self-closing slash, and
  for upper-case element tag names

- Issue BorisMoore/jsviews#175
  Provide TypeScript definition files

- Issue BorisMoore/jsrender#211
  Provide TypeScript definitions
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Nov 25, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue BorisMoore/jsviews#409
  Datepicker fails when convertors in use

- Issue BorisMoore/jsviews#209
  Improved support for void elements with no self-closing slash, and
  for upper-case element tag names

- Issue BorisMoore/jsviews#175
  Provide TypeScript definition files

- Issue BorisMoore/jsrender#211
  Provide TypeScript definitions
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Nov 26, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue BorisMoore/jsviews#409
  Datepicker fails when convertors in use

- Issue BorisMoore/jsviews#209
  Improved support for void elements with no self-closing slash, and
  for upper-case element tag names

- Issue BorisMoore/jsviews#175
  Provide TypeScript definition files

- Issue BorisMoore/jsrender#211
  Provide TypeScript definitions
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Nov 26, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue BorisMoore/jsviews#409
  Datepicker fails when convertors in use

- Issue BorisMoore/jsviews#209
  Improved support for void elements with no self-closing slash, and
  for upper-case element tag names

- Issue BorisMoore/jsviews#175
  Provide TypeScript definition files

- Issue BorisMoore/jsrender#211
  Provide TypeScript definitions
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Nov 26, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue BorisMoore/jsviews#409
  Datepicker fails when convertors in use

- Issue BorisMoore/jsviews#209
  Improved support for void elements with no self-closing slash, and
  for upper-case element tag names

- Issue BorisMoore/jsviews#175
  Provide TypeScript definition files

- Issue BorisMoore/jsrender#211
  Provide TypeScript definitions
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Nov 27, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue BorisMoore/jsviews#409
  Datepicker fails when convertors in use

- Issue BorisMoore/jsviews#209
  Improved support for void elements with no self-closing slash, and
  for upper-case element tag names

- Issue BorisMoore/jsviews#175
  Provide TypeScript definition files

- Issue BorisMoore/jsrender#211
  Provide TypeScript definitions
BorisMoore added a commit that referenced this issue Nov 27, 2018
JsRender, JsObservable and JsViews are now all stable v1.0.0 releases:

- This update moves from the previous beta releases to the first official
  non-beta release: v1.0.0, both for jsrender.js and jsviews.js.

- There will be no further major breaking changes before v2.0.0

TypeScript definition fles now available:

- This update provides TypeScript definition files, see https://www.jsviews.com#typescript

Documentation:

- API documentation for JsViews, JsObservable and JsViews is now complete.
  It includes extensive new documentation, including:
  - JsRender objects - at https://www.jsviews.com#jsrobjects
  - JsViews objects - at https://www.jsviews.com#jsvobjects

Minor bug fixes:

- This update includes some minor bug fixes, and some added code comments.

- Issue #211
  Provide TypeScript definitions
@BorisMoore
Copy link
Owner

JsViews and JsRender have both been released as v1.0.0 (https://www.jsviews.com/#download) - including TypeScript definitions here.

I will look into NuGet deployment. @michael-lang - we could collaborate on that if you are interested...

@BorisMoore
Copy link
Owner

BorisMoore commented Jan 23, 2019

See also #232 (composer)

@Jogai
Copy link

Jogai commented Mar 12, 2019

I cant seem to find the correct type packages. I have @types/jsrender, but those are made by Kensuke Matsuzaki @zakki

@BorisMoore
Copy link
Owner

They can be found via links on this page "https://www.jsviews.com/#typescript":

https://www.jsviews.com/download/typescript/jsrender/index.d.ts
https://www.jsviews.com/download/typescript/jsviews/index.d.ts

Don't do npm install @types/jsrender. They are not yet published there, on DefinitelyTyped.

@Jogai
Copy link

Jogai commented Mar 15, 2019

Ok, but this is non-standard, and having one package on the registry makes it more confusing. I'll rather have it like momenjs does, just distribute it along in the main package.

@BorisMoore
Copy link
Owner

BorisMoore commented Mar 15, 2019

@Jogai: Like it says: "Both will be published to DefinitelyTyped". I am working on that, and will publish when ready.

Including in the main package is not recommended except for packages written in TypeScript. See https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

@BorisMoore
Copy link
Owner

Typescript definitions have been published.

See https://www.jsviews.com/#typescript, and discussion here: BorisMoore/jsviews#434

@BorisMoore
Copy link
Owner

Also WebPack support is implemented: https://www.jsviews.com/#node/webpack

@BorisMoore BorisMoore changed the title Create a NuGet package and typescript definitions Create a NuGet package Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants