Get file size from S3 after upload + fix upload #4952
Conversation
| /** | ||
| * Allows to resolve an ''S'' to an ''A'' | ||
| */ | ||
| trait Lens[S, A] { |
| /** | ||
| * Convert the array of bytes to a string of the hexadecimal values | ||
| */ | ||
| def valueOf(value: Array[Byte]): String = value.map("%02x".format(_)).mkString |
There was a problem hiding this comment.
Common shared utility method
| final case object NotComputedDigest extends Digest { | ||
| override val computed: Boolean = false | ||
| } | ||
| final case object NoDigest extends Digest |
There was a problem hiding this comment.
This is slightly different from the other one (NotComputedDigest) where we were expecting it to be computed in the future
| /** | ||
| * Rejection returned when a file can not be saved because content-length is not provided | ||
| */ | ||
| final case object ContentLengthIsMissing |
There was a problem hiding this comment.
When doing a put with a stream and asking for a checksum, it seems that the content length is needed
| case class HeadObject(fileSize: Long, contentType: Option[ContentType], digest: Digest) | ||
|
|
||
| object HeadObject { | ||
| def apply(response: HeadObjectResponse): HeadObject = { |
There was a problem hiding this comment.
Smart constructor to add more value to the class
| http { | ||
| client { | ||
| parsing { | ||
| max-content-length="100g" |
There was a problem hiding this comment.
To test with larger files
| extraHeaders: Seq[HttpHeader] = jsonHeaders | ||
| )(assertResponse: (A, HttpResponse) => Assertion)(implicit um: FromEntityUnmarshaller[A]): IO[Assertion] = { | ||
| def buildClue(a: A, response: HttpResponse) = | ||
| def uploadFile(project: String, storage: String, file: FileInput, rev: Option[Int])( |
There was a problem hiding this comment.
I refactored the tests to do a general use of FileInput
| @@ -309,4 +311,27 @@ class S3StorageSpec extends StorageSpec { | |||
| } yield assertion | |||
| } | |||
| } | |||
|
|
|||
| "Uploading a large file" should { | |||
| "succeed" ignore { | |||
There was a problem hiding this comment.
Ignored for now as it takes ~2min to complete
We may want to introduce a slow tag for those and still run them from time to time in a scheduled fashion
(there is at least another one for archives iirc)
Fixes #4944