New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish and document S3 link endpoint #4914

Closed

dantb opened this issue Apr 30, 2024 · 1 comment

Labels

delta

Contributor

dantb commented Apr 30, 2024 •

edited by imsdu

This was done quickly to get nexus ship unblocked. Potential improvements:

Do we need a creation endpoint where we generate an Id, or is just one with the Id passed fine in this case? Yes
Endpoint names could be improved, depending on who will call them. (All changes must be reflected in ship)
Better name for FileAttributesOrigin.External? => Link
Write documentation (if it's needed outside our team, if it's only used by nexus ship then docs are unlikely to be worth writing): Yes for the DKE team

The text was updated successfully, but these errors were encountered:

dantb added the delta label

imsdu changed the title ~~Polish and document S3 registration endpoint~~ Polish and document S3 link endpoint

Contributor

imsdu commented May 15, 2024

New tickets #4971 and #4974

imsdu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment