Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Trie container to not need an EndSymbol #149

Open
MakoEnergy opened this issue May 27, 2017 · 0 comments
Open

Refactor the Trie container to not need an EndSymbol #149

MakoEnergy opened this issue May 27, 2017 · 0 comments

Comments

@MakoEnergy
Copy link
Member

Currently in the Trie implementation we have we cannot accept an iterator pair. The api simply doesn't support that. Instead we pass in a pointer with the expectation that it will be terminated by a user defined end symbol. This is a C-style approach, not C++.

It would take reworking a number of the methods to be template functions but they should be rewritten to handle iterator pairs being passed into them rather than c-style arrays. The iterator pair defines the bounds, rather than a terminator. This affords us better optimizations and flexibility when performing checks against the Trie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant