Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input - Separate device logic that requires MetaCode deltas and logic that doesn't. #146

Open
MakoEnergy opened this issue May 13, 2017 · 0 comments

Comments

@MakoEnergy
Copy link
Member

Currently Input devices have a singular update method that performs all of the update logic. During the more recent refactor of the system I tried to add an early escape in the event that no new inputs were detected, however this broke some device behaviors (such as resetting the mouse wheel state).

Some devices have updates that need to be performed regardless, but we shouldn't have to pay for all the other checks involved when updating with MetaCodes when none exist. So the two forms of logic should be separated somehow and we should have an early out when no MetaCodes are detected that frame.

InputManager::UpdateInputDevices() has a todo commenting on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant