Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Btc #2270

Open
SteveBombardier opened this issue Dec 21, 2023 · 0 comments
Open

Btc #2270

SteveBombardier opened this issue Dec 21, 2023 · 0 comments

Comments

@SteveBombardier
Copy link

bc1q26c9e8lkn8mcu85u2dp39h8xp4l2c3ph6c2j3f
sickpig pushed a commit that referenced this issue May 30, 2024
@cculianu
Fix "chipnet" having an empty chain name on some implementations
a2c8375 
Summary
---

Fixes #2270.

Chipnet has an empty chain name on some implementations because the
static std::string name it depends upon when constructed may not be alive yet due
to order of initialization issues on some platforms.

This commit fixes the situation.  Note that the other networks also are
using hard-coded C-strings here such as "main" and "scale", etc. ChipNet
was the only one referring to one of those `static std::string CBaseChainParams::`
objects.

Test Plan
---

- `make check`
- See if you can reproduce the issue in #2270
- If you can, ensure that with this MR it's fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SteveBombardier