-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting 'Rescan is disabled in pruned mode' even thought I set rescan false... #1585
Comments
When you import a private key in pruned mode you can't be guaranteed
that your wallet will be up to date because most of the blocks are/may
not there to scan for valid transactions. That's probably why we
disabled it in pruned node (if we did, i really dont' recall). When in
pruned mode you really do have to re-sync the whole chain to be sure you
have your balance up to date.
That said, if you knew say that this was a recent priviate key, more
recent that the oldest blocks you have in your chain, then maybe there
should be some sort of override that we could code in place so that you
could do that (but it would be a risk that you may have missed some
wallet entries if you were wrong in the num of blocks you have available
to scan)
)On 31/01/2019 5:21 p.m., ChainTip wrote:
…
Trying to get ChainTip reddit up and running again. I'm running pruned
nodes as before to save money. When I try to import a private key
setting rescan to false I get the following error:
***@***.***:~# bitcoin-cli importprivkey
"L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK" "" false error
code: -4 error message: Rescan is disabled in pruned mode |
Unless I'm doing something stupid, this used to work. Has something
changed that might stop this from working anymore?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1585>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0Dy9otC4BG28z_jvVz2k5ZpZqYnAks5vI5aegaJpZM4adedr>.
|
btw, re-sync is really fast now anyway...on a fast ssd system will take
just 2 to 3 hours.
…On 31/01/2019 5:21 p.m., ChainTip wrote:
Trying to get ChainTip reddit up and running again. I'm running pruned
nodes as before to save money. When I try to import a private key
setting rescan to false I get the following error:
***@***.***:~# bitcoin-cli importprivkey
"L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK" "" false error
code: -4 error message: Rescan is disabled in pruned mode |
Unless I'm doing something stupid, this used to work. Has something
changed that might stop this from working anymore?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1585>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0Dy9otC4BG28z_jvVz2k5ZpZqYnAks5vI5aegaJpZM4adedr>.
|
My problem is the cost of running two full nodes that aren't pruned. In my case, I generate the private key so I know it's not been used before. I also know that I came across this error when initially trying (creating the service) to do the equivalent of bitcoin-cli importprivkey "L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK" through bitcoin-rpc. i.e. no label and no rescan option given. I had to figure out how to add these to make it work for me. An override would be great here to put the functionality back to how it was if it did indeed change and I'm not doing something stupid.
I thought this (putting label and rescan options) was the override :D |
ok thanks, yes i agree it should be made possible to import a brand new
key into a pruned node...we probably turned it off not thinking about
that use case...but maybe it would be better to have either a separatre
rpc command for this of possibly an override, but there already is an
override there so not sure another will make everything clearer...I'll
sleep on it and open a PR to resolve this one way or the other.
Thanks for the reporting.
For now, as a work around you could startup a fresh node at block 0, not
in pruned mode, then import your private key. Then stop and re-start
and sync the chain this time in pruned mode.
…On 31/01/2019 5:46 p.m., ChainTip wrote:
My problem is the cost of running two full nodes that aren't pruned no
that the resync takes a long time.
In my case, I generate the private key so I know it's not been used
before.
I also know that I came across this error when initially trying
(creating the service) to do the equivalent of bitcoin-cli
importprivkey "L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK"
through bitcoin-rpc. i.e. no label and no rescan option given. I had
to figure out how to add these to make it work for me.
An override would be great here to put the functionality back to how
it was if it did indeed change and I'm not doing something stupid.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1585 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0HdbNr4ROfxZHySBHLolPtcydqj2ks5vI5ySgaJpZM4adedr>.
|
Great, thanks a lot! The way my bot works, I grab new addresses off my database whenever someone asks the bot to make a tip. It is possible to do what you suggest but will take quite some effort. Can you point me to where this logic happens and I can hack it myself and recompile it? Do you know if some of the other implementations (say ABC) have this switched off too? If I don't manage to hack it or use another implementation, what size VPS would you recommend using these days to run a unpruned node? |
Hmm, looking at the code I wonder if there's a bug here...can you try
adding a label when you try to import...
so do this:
importprivkey <your key> <some wallet label> false
…On 01/02/2019 1:19 a.m., ChainTip wrote:
Great, thanks a lot!
The way my bot works, I grab new addresses off my database whenever
someone asks the bot to make a tip. It is possible to do what you
suggest but will take quite some effort. Can you point me to where
this logic happens and I can hack it myself and recompile it?
Do you know if some of the other implementations (say ABC) have this
switched off too?
If I don't manage to hack it or use another implementation, what size
VPS would you recommend using these days to run a unpruned node?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1585 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0MliQ4Vw0vNZcZ-ubuKffnZsSXjmks5vJAawgaJpZM4adedr>.
|
ah yes, just tested that, it works...it needed the label.
…On 01/02/2019 1:19 a.m., ChainTip wrote:
Great, thanks a lot!
The way my bot works, I grab new addresses off my database whenever
someone asks the bot to make a tip. It is possible to do what you
suggest but will take quite some effort. Can you point me to where
this logic happens and I can hack it myself and recompile it?
Do you know if some of the other implementations (say ABC) have this
switched off too?
If I don't manage to hack it or use another implementation, what size
VPS would you recommend using these days to run a unpruned node?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1585 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0MliQ4Vw0vNZcZ-ubuKffnZsSXjmks5vJAawgaJpZM4adedr>.
|
I did try this. Tried it again though now at your request. Same result, unless I'm doing something wrong. root@bu:~# bitcoin-cli importprivkey "L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK" "label" false root@bu:~# bitcoin-cli importprivkey "L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK" label false root@bu:~# bitcoin-cli importprivkey L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK label false |
that's wierd: can you try this one, this is a different command for importing multiple keys but you can do just one. importprivatekeys no-rescan "yourkey" |
Are you two running the same exact version pf BU? See #1549 |
i'm running current dev...
i didn't know that was fixed just recently so it would not be in the
release branch but only in dev
…On 01/02/2019 8:18 a.m., Tom Harding wrote:
Are you two running the same exact version pf BU? See #1549
<#1549>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1585 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0CB_hPzzvL_3ibnfJoZlmR9f0MJvks5vJGjAgaJpZM4adedr>.
|
root@bu:~# bitcoin-cli importprivkey no-rescan "L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK" Yeah, I'm running the release. Thanks for notifying us of #1549 @dgenr8! When will the next release be pushed? If it's not soon, I'll use the current dev version. And thanks @ptschip for helping me sort this out! |
I would compile dev or if just pull in that commit from dev into release
…On 01/02/2019 11:32 a.m., ChainTip wrote:
***@***.***:~# bitcoin-cli importprivkey no-rescan
"L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK"
error code: -4
error message:
Rescan is disabled in pruned mode
Yeah, I'm running the release. Thanks for notifying us of #1549
<#1549>
@dgenr8 <https://github.com/dgenr8>!
When will the next release be pushed? If it's not soon, I'll use the
current dev version.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1585 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRF0Hypf-UZXDZ_pbywJwNONpEnuAa1ks5vJJZJgaJpZM4adedr>.
|
@ptschip, @dgenr8 ... not quite sure what I'm doing wrong. Followed the instructions here to compile from source: https://github.com/BitcoinUnlimited/BitcoinUnlimited#quick-installation-instructions It takes quite a while. Didn't work the first time when trying 'root@buw:~# bitcoin-cli importprivkey L3AXbZnPNeprMYtPKLNxyJD5vMUsihtkpw52GqYrfxnTS1pST8uK label false again. Tried again on another VPS. Didn't work again. Made sure to checkout 'dev' instead of 'release'. Any ideas? |
What does |
Bitcoin Unlimited Cash Edition v1.5.1.0-f6b0c75cb |
The bitcoin-cli version looks fine. Is there a chance the bitcoind it's connecting to is not a dev build? |
Yes, just checked. There were two running. Thank you! |
Shall we leave this issue open until a new release comes so that others can find it easily if they have the same problem? |
Trying to get ChainTip reddit up and running again. I'm running pruned nodes as before to save money. When I try to import a private key setting rescan to false I get the following error:
Unless I'm doing something stupid, this used to work. Has something changed that might stop this from working anymore?
The text was updated successfully, but these errors were encountered: