Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Problem removing keyboard shortcuts after uninstall #137

Open
nivaca opened this issue Oct 27, 2021 · 3 comments · May be fixed by #144
Open

[Bug]: Problem removing keyboard shortcuts after uninstall #137

nivaca opened this issue Oct 27, 2021 · 3 comments · May be fixed by #144
Labels
bug Something isn't working confirmed The bug has been reproduced good first issue Good for newcomers

Comments

@nivaca
Copy link

nivaca commented Oct 27, 2021

Summary

I uninstalled Bismuth using the supplied uninstaller (in the source archive). It correctly uninstalled Bismuth but left all the keyboard bindings (in System Settings -> Shortcuts -> Kwin). How can I remove them?

Steps to Reproduce

  1. Install Bismuth using the supplied installer in the archive: npm run script-install
  2. Uninstall it now: npm run script-uninstall

I get the following confirmation:

> bismuth@1.1.0 script-uninstall
> bin/uninstall.sh

Successfully uninstalled

However, the keybindings are still left.

Expected behavior

The keybindings should disappear after uninstall.

Screenshots

2021-10-27_09-12

Bismuth version

1.1.0

KDE Plasma version

5.22.5

The platform KWin is running on

X11

Additional context

No response
@nivaca nivaca added the bug Something isn't working label Oct 27, 2021
@gikari
Copy link
Member

gikari commented Oct 29, 2021

I am not sure baking the shortcuts' removal into the uninstallation is a good idea. What if the user wants to preserve the shortcuts to reinstall the software?

What could be done is a separate script in contrib/, that removes shortcuts.

You can also do it manually by deleting entries in the ~/.config/kglobalshortcutsrc starting with bismuth_ and the reloading the shortcut daemon (not sure what the name is. Once I found out, I can fix #90 and #96 ).

@gikari gikari added confirmed The bug has been reproduced help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Oct 29, 2021
@nivaca
Copy link
Author

nivaca commented Oct 29, 2021

You're right about the user's wanting to keep the shortcuts, but that may also be an option.
I just created a script for that and made a pull request.

This was referenced Oct 29, 2021
Closed
Open
@fourteenminusone
Copy link

fourteenminusone commented Jan 24, 2022 •
edited

Hi,

I manually edited kglobalshortcutsrc file removimg all bismuth entries, but GUI entries in kWin menu still remain. After rebooting also kglobalshortcutsrc turns to contain bismuth entries.

Could you check please?

EDIT:

I found a solution for the problem in subject:

  • edit kglobalshortcutsrc removing all bismuth entries and save kglobalshortcutsrc
  • run kquitapp5 kglobalaccel && sleep 2s && kglobalaccel5 & from a shell

This way, Bismuth shortcuts entries will disappear from Settings menu and even after restarting the session and it seems that the settings are really saved and loaded correctly.

References
https://www.reddit.com/r/kde/comments/e2ew10/reload_global_shortcuts_config/
https://www.reddit.com/r/kde/comments/6u0wo7/configuring_kde_by_editing_the_config_files/dlqzeop/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed The bug has been reproduced good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@nivaca @gikari @fourteenminusone