Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crupR submission #3413

Open
10 tasks done
akbariomgba opened this issue May 8, 2024 · 8 comments
Open
10 tasks done

crupR submission #3413

akbariomgba opened this issue May 8, 2024 · 8 comments
Assignees
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK

Comments

@akbariomgba
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @akbariomgba

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: crupR
Type: Package
Title: an R package to predict condition-specific enhancers from ChIP-seq data
Version: 0.99.0
Authors@R: c(
   person("Persia", "Akbari Omgba", email = "omgba@molgen.mpg.de", role = c("cre")),
   person("Verena", "Laupert", email = "verena.laupert@bayer.com", role = c("aut")),
   person("Martin", "Vingron", email = "vingron@molgen.ppg.com", role = c("aut")))
Description: An R package offers a workflow to predict condition-specific enhancers from ChIP-seq data.
    The prediction of regulatory units is done in four main Steps:
    Step 1 is the normalization of the ChIP-seq counts.
    Step 2 is the actual prediction of active enhancers bin-wise on the whole genome.
    Step 3 is the condition-specific clustering of the putative active enhancers.
    Step 4 is the search for possible target genes of the condition-specific clusters using RNA-seq counts.
License: GPL-3
Encoding: UTF-8
LazyData: false
Imports: 
    BSgenome.Mmusculus.UCSC.mm10,
    BSgenome.Mmusculus.UCSC.mm9,
    BSgenome.Hsapiens.UCSC.hg19,
    BSgenome.Hsapiens.UCSC.hg38,
    bamsignals,
    Rsamtools,
    GenomicRanges,
    preprocessCore,
    randomForest,
    rtracklayer,
    GenomeInfoDb,
    S4Vectors,
    parallel,
    ggplot2,
    matrixStats,
    dplyr,
    IRanges,
    GenomicAlignments,
    GenomicFeatures,
    TxDb.Mmusculus.UCSC.mm10.knownGene,
    TxDb.Mmusculus.UCSC.mm9.knownGene,
    TxDb.Hsapiens.UCSC.hg19.knownGene,
    TxDb.Hsapiens.UCSC.hg38.knownGene,
    BSgenome,
    reshape2,
    magrittr,
    stats,
    utils,
    grDevices
Depends:
    R (>= 4.2.0)
Suggests: testthat, BiocStyle, knitr, rmarkdown
biocViews:
    DifferentialPeakCalling,
    GeneTarget,
    FunctionalPrediction,
    HistoneModification,
    PeakDetection
BiocType: Software
URL: https://github.com/akbariomgba/crupR
RoxygenNote: 7.2.3
VignetteBuilder: knitr

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label May 8, 2024
@lshep
Copy link
Contributor

lshep commented May 20, 2024

I currently cannot build the package

R CMD build crupR 
* checking for file 'crupR/DESCRIPTION' ... OK
* preparing 'crupR':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘crupR-vignette.Rmd’ using rmarkdown

Quitting from lines  at lines 167-168 [unnamed-chunk-11] (crupR-vignette.Rmd)
Error: processing vignette 'crupR-vignette.Rmd' failed with diagnostics:
object 'C_pKS2' not found
--- failed re-building ‘crupR-vignette.Rmd’

SUMMARY: processing the following file failed:
  ‘crupR-vignette.Rmd’

Error: Vignette re-building failed.
Execution halted

@lshep lshep added the 3e. pending pre-review changes review has indicated blocking concern that needs attention label May 20, 2024
@akbariomgba
Copy link
Author

Hello,
When I am trying to build the package it runs w/o any errors, so I have trouble finding the bug. Could you please provide your session info or other information about your environment such that I can replicate it?

@lshep
Copy link
Contributor

lshep commented May 22, 2024

R CMD build crupR 
* checking for file 'crupR/DESCRIPTION' ... OK
* preparing 'crupR':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘crupR-vignette.Rmd’ using rmarkdown

Quitting from lines 167-168 [unnamed-chunk-11] (crupR-vignette.Rmd)
Error: processing vignette 'crupR-vignette.Rmd' failed with diagnostics:
object 'C_pKS2' not found
--- failed re-building ‘crupR-vignette.Rmd’

SUMMARY: processing the following file failed:
  ‘crupR-vignette.Rmd’

Error: Vignette re-building failed.
Execution halted

My sessionInfo()

Bioconductor version 3.20 (BiocManager 1.30.23), R 4.4.0 Patched (2024-04-30
  r86503)
> sessionInfo()
R version 4.4.0 Patched (2024-04-30 r86503)
Platform: x86_64-pc-linux-gnu
Running under: Ubuntu 22.04.4 LTS

Matrix products: default
BLAS:   /home/lorikern/R-Installs/bin/R-4-4-branch/lib/libRblas.so 
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.10.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

time zone: America/New_York
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] praise_1.0.0        BiocManager_1.30.23

loaded via a namespace (and not attached):
[1] compiler_4.4.0

@akbariomgba
Copy link
Author

Thank you for the session info. I was able to reproduce the bug and fixed it. The repo has been updated.

I apologize for the inconvenience.

@lshep lshep added pre-check passed pre-review performed and ready to be added to git and removed 3e. pending pre-review changes review has indicated blocking concern that needs attention labels May 28, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels May 29, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.3 LTS): crupR_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
git@git.bioconductor.org:packages/crupR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Jun 3, 2024
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK
Projects
None yet
Development

No branches or pull requests

4 participants