New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style 3 bottom nav bar text style issue #119
Comments
Thank you I'll fix it in the upcoming update. |
Seems that the textStyle property for every individual item on the style3 type it cannot be used! |
Is this issue resolved? or any work around? |
Still no updates. Just encountered this issue recently. |
Until the PR is merged, If you took my PR changes, it should fix the issue. |
I've upgraded to 3.0.0 and noticed that titleFontSize property has been removed, and textStyle property is added. so I updated my code to use
textStyle: const TextStyle(fontSize: 10.0)
to adapted the change, however, it doesn't seem to work, it throws out type 'TextStyle' is not a subtype of type 'Color?'. error.By reading the 'style-3-bottom-nav-bar.widget.dart' source code, I don't think it will accept the font size as it's using DefaultTextStyle.merge to take care of color and ignore the passed in textStyle, so the fontSize will always be 12.0 and other text styles will get ignored?
I think other themes don't have this problem as they use
item.textStyle.apply
to include the passed-in style value(such as style-9-bottom-nav-bar.widget.dart file), do we want to fix style 3 theme issue if it's not intended, I can provide a PR if the current behavior is not intended.The text was updated successfully, but these errors were encountered: