Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Edit app.asar in a way such that BetterDiscord is installed with every Discord update! #1729

Open
1 task done
H-A-M-G-E-R opened this issue Mar 19, 2024 · 6 comments

Comments

@H-A-M-G-E-R
Copy link

Before Requesting

  • I found no existing issue matching my feature request

Describe the feature you'd like!

And also have the ability to rollback Discord updates and stop forced updates!

Anything else?

I think app.asar has the updator logic but it may also be in the Discord executable so we may need Ghidra for that.

@H-A-M-G-E-R
Copy link
Author

and why there are always 13 updates instead of a random number

@H-A-M-G-E-R
Copy link
Author

but when i edit app.asar discord refuses to start how to fix that

@Riddim-GLiTCH
Copy link

You can bypass any host updates by adding the following rule to discord/settings.json

{
    "SKIP_HOST_UPDATE": true
}

An example of which can be seen in this screenshot.
image

I do not believe this will resolve the issue of Discord patching out BetterDiscord on host updates, as occasionally, the app.asar file in question also gets overwritten by Discord host updates.

Additionally, I can highly reccomend OpenAsar which allows you to skip update checks on starup, which should also allow you to bypass host updates.

Currently, I am aware of the BetterDiscord installer package being rewritten in wails in the hopes of adding more control of BetterDiscord injection being a bit more permanent.

I hope these workarounds are helpful to you until a solution is found.

@bluedoomcapZZang
Copy link

저건 남에게나 도둑넘이지..

@PaperVb64
Copy link

I do not believe this will resolve the issue of Discord patching out BetterDiscord on host updates, as occasionally, the app.asar file in question also gets overwritten by Discord host updates.

Couldn't you just bundle a file that checks if the discord app is updated, than patches the asar?

@Riddim-GLiTCH
Copy link

I do not believe this will resolve the issue of Discord patching out BetterDiscord on host updates, as occasionally, the app.asar file in question also gets overwritten by Discord host updates.

Couldn't you just bundle a file that checks if the discord app is updated, than patches the asar?

Technically yes, but you would have to have a subprocess that checks when Discord's Sr has changed to then kill it, then reinstall better Discord and then start Discord again. Due to better Discord needing an entire app restart in order to load correctly, this experience will be janky to the user to say the least. And I do believe that a lot of users will complain that their Discord is not starting correctly or starting very weirdly if this is to be implemented. Worse yet, I do believe some might complain that their Discord might be infected with malware seeing as how better Discord already has a bit of a tarnished reputation for some infected binaries being spread on the internet and people not checking where they got their binaries from, but just blaming the name of the app.

Either way, I think the manager that is upcoming is a better idea than just having a thing that kills Discord after it's already started. Then restart Discord with BD injected as if nothing happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants