Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move plugin configs outside of plugin folder #1471

Open
1 task done
ColonelGerdauf opened this issue Nov 3, 2022 · 6 comments
Open
1 task done

[Feature] Move plugin configs outside of plugin folder #1471

ColonelGerdauf opened this issue Nov 3, 2022 · 6 comments

Comments

@ColonelGerdauf
Copy link

Before Requesting

  • I found no existing issue matching my feature request

Describe the feature you'd like!

I am hoping this is possible in the scope of Javascript.

What I want to have is a situation where the config.json data files and other data files are loaded from another directory, for example inside of BetterDiscord\data\. Ideally in its own plugin-data folder, so that will allow a much cleaner plugins directory, and will allow a much cleaner directory for when someone wants to change something manually.

Anything else?

No response

@Riddim-GLiTCH
Copy link

Wouldn't it make more sense to move the configs to BetterDiscord/Plugins/Config?

@ColonelGerdauf
Copy link
Author

That would be fair, given that it will make things easier for plugin devs when it comes to troubleshooting.
That being said, I was of a mindset that since there is plugin data, that it should fall into the data folder of BD.

In either case, it was only a suggestion. It is not my say in where the data files should be, just as long as the core idea is accomplished.

@Riddim-GLiTCH
Copy link

I mean this is a valid suggestion if you ask me. It would help clean up the plugins folder, like you said, making it easier to debug issues.

@ColonelGerdauf
Copy link
Author

It is beneficial on both sides, as you are clear when you are looking for plugins or plugin data. As it is now, it can get confusing in small, and very cluttered in large sets of plugins. Not to mention, once a person deletes a plugin through BD, the data file remains, which adds another layer of confusion in the Plugins directory.

@rauenzi rauenzi changed the title [Feature] Organize plugin folder [Feature] Move plugin configs outside of plugin folder Mar 4, 2023
@rauenzi
Copy link
Member

rauenzi commented Feb 25, 2024

Coming back to this... I'm undecided which of these schemes is best suited for this. In all cases I'm okay with either using config or data as the main term. Then there's a split of whether the data should be the same across all release channels (stable, canary, ptb) which is how they currently are or separate like BD config data. Here are the options I've been considering:

Same data across channels

  1. Individual json files under BetterDiscord/plugins/data
  2. Individual json files under BetterDiscord/data
  3. Combined json in BetterDiscord/data/plugin_data.json

Channel-specific data

  1. Individual json files under BetterDiscord/data/{channel}/plugins or BetterDiscord/data/{channel}/plugin_data
  2. All plugins combined under separate keys in BetterDiscord/data/{channel}/plugin_data.json

Currently I'm leaning toward option 1 under channel-specific data, but I'm open to hearing others thoughts. Option 1 under same-data also has a certain clean appeal.

@Riddim-GLiTCH
Copy link

Riddim-GLiTCH commented Feb 26, 2024

Currently I'm leaning toward option 1 under channel-specific data.

I second this option. Perhaps plugins should also be able to make their own folders within this folder. In case a plugin, for example: Devilbro's Library, requires multiple files; like this BetterDiscord/data/[channel]/plugin-data/BDFDB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants