Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MountTable.lua:2: attempt to index global 'C_MountJournal' (a nil value) #264

Open
rbpaiett opened this issue Oct 12, 2023 · 9 comments
Open
Labels
type: bug A small patch

Comments

@rbpaiett
Copy link

WoW Version

WotLK (3.4.0)

Bestride Version

2.0.16

Steps to Reproduce

Just simply logon, the error appears without doing anything.

You also have to be in the Classic Era realm 1.14.4. That version isn't available in your form.

Observed Behavior

Message: ...erface/AddOns/BeStride/Versions/Wrath/MountTable.lua:2: attempt to index global 'C_MountJournal' (a nil value)
Time: Wed Oct 11 20:03:52 2023
Count: 1
Stack: ...erface/AddOns/BeStride/Versions/Wrath/MountTable.lua:2: attempt to index global 'C_MountJournal' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65>
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615> [string "=[C]"]: in function LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11553: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventoryTradeskill.lua"]:749: in function ScanHeaders'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:3305: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3129>
[string "=[C]"]: ?
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65>
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function `EnableAddon'
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615>

Locals: (*temporary) = defined @Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:61

@rbpaiett rbpaiett added the type: bug A small patch label Oct 12, 2023
@TylerR909
Copy link
Contributor

TylerR909 commented Oct 12, 2023

@DanSheps FYI:

  • BeStride_Vanilla.toc is pulling in Versions\BeStride_Wrath.xml
    • for what it's worth BeStride_Clasic.xml has a typo (one s vs ss).
  • I guess I didn't add <Script file="Common\opie.lua"/> to Classic.xml.
  • between the 3 XML files it looks like some translations are missing? May want to do a cleanup pass on that.
  • You may also want to disable or hide the mount.copytargetmount option if BeSTride:IsClassicEra() (which is also a capitalization typo) given it's just return nil for now.
    • typo

Sorry I'm not around to help right now. 😞

@rbpaiett
Copy link
Author

Ok, let's see what light patching I can do in the meantime does for it.

@rbpaiett
Copy link
Author

I can't find the option mount.copytargetmount in any of these files. Where would I find it?

@rbpaiett
Copy link
Author

Ok, I made those changes except that part about mount.copytargetmount and I got the following:

Message: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number
Time: Thu Oct 12 11:36:46 2023
Count: 1
Stack: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number
[string "=[C]"]: ?
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65>
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615> [string "=[C]"]: in function LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11553: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventoryTradeskill.lua"]:749: in function ScanHeaders'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:3305: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3129>
[string "=[C]"]: ?
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65>
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function `EnableAddon'
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615>

Locals: (*temporary) = defined @Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:61

@rbpaiett
Copy link
Author

It might be because it's replaced by C_MountJournal.GetNumDisplayedMounts

@rbpaiett
Copy link
Author

Hmm, C_MountJournal yielded nil.

@rbpaiett
Copy link
Author

Ok, I downloaded your latest changes and deleted the saved variables. I got the following error:

Message: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number
Time: Thu Oct 12 12:52:33 2023
Count: 1
Stack: ...face/AddOns/BeStride/Versions/Classic/MountTable.lua:3: 'for' limit must be a number
[string "=[C]"]: ?
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65>
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615> [string "=[C]"]: in function LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11553: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventoryTradeskill.lua"]:749: in function ScanHeaders'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:3305: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3129>
[string "=[C]"]: ?
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:70: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:65>
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:527: in function `EnableAddon'
[string "@Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua"]:630: in function <.../AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:615>

Locals: (*temporary) = defined @Interface/AddOns/DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:61

@DanSheps
Copy link
Collaborator

I don't play classic, so I will need to login and give it a try. Give me a few days.

@DanSheps DanSheps reopened this Oct 13, 2023
@rbpaiett
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A small patch
Projects
None yet
Development

No branches or pull requests

3 participants