Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge SVN based fork #1

Open
adamoutler opened this issue Nov 18, 2013 · 3 comments
Open

merge SVN based fork #1

adamoutler opened this issue Nov 18, 2013 · 3 comments

Comments

@adamoutler
Copy link

Over at the CASUAL-Dev project I forked libpit--Java- and revised it. When I began working with it, it was barely functional and could not read what it wrote out.

Changes:
Implemented result-based testing
added unknowns
set data lengths to proper size
updated names of variables
updated names of getters and setters
added convenience constructors
add the ability to sign pit files from an original file
Added a new PitFormatException
Implemented testing based on my own changes

Challenges during merge:
The best merge strategy would likely be replacement of existing files.
You will need to change the "package CASUAL.archiving.libpit;" at the top of each file.
To add test code, place the test code anywhere, change the package reference and change the relative reference to "../test/CASUAL/network/CASUALDevIntegration/resources/sch-i535-32gb.pit" to your own package.

Source can be found here: https://code.google.com/p/android-casual/source/browse/#svn%2Ftrunk%2FCASUALcore%2Fsrc%2FCASUAL%2Farchiving%2Flibpit

Test Code can be found here: https://code.google.com/p/android-casual/source/browse/trunk/CASUALcore/test/CASUAL/archiving/libpit/PitDataTest.java

Test Code subject can be found here: https://android-casual.googlecode.com/svn/trunk/CASUALcore/test/CASUAL/network/CASUALDevIntegration/resources/sch-i535-32gb.pit

@adamoutler
Copy link
Author

I performed some more changes today:
Added PrintPit functionality
Added toString on PitData and PitEntry
Removed PitFormatException
Added Javadoc to all LibPit items
Added 40 tests to LibPit
Added resource files for archiving formats

The end result of all of this is 100% testing on this version of LibPit. LibPit has 100% of public documenation. And, LibPit's PrintPit.main(String args) will take a filename and print out something like this from my Galaxy Camera:
http://pastebin.ubuntu.com/6446047/

The new print-pit class simply utilizes the same toString() methods used for debugging. Here is a picture of the PitEntry.toString() methods in-action while debugging.
https://lh4.googleusercontent.com/-73ThopPckvk/UowjuTtDu6I/AAAAAAAAt1o/CTESSQRlbLw/w1284-h670-no/pitfile.png

I think this should be final with only minor review required from here out.

@adamoutler
Copy link
Author

In Revision 912: https://code.google.com/p/android-casual/source/detail?r=912 I forked the print-pit away from the standard, in favor of asthetics and analysis of the underlying values. The output has been changed quite a bit.
I've put up all the information about my changes here: http://forum.xda-developers.com/showthread.php?p=47780778#post47780778

@Benjamin-Dobell
Copy link
Owner

@adamoutler You've made a lot of changes and I think it would be fair to say that the vast majority is your own work. Given it's mostly your work I think it would make more sense for me to deprecate this version of the library and for you upload libpitx directly to your own Github account.

I assign all ownership rights to you (i.e. Adam Outler) for any of the code I wrote that is left in your fork. So feel free to remove my copyright headers and license your code however you please. Although, I would appreciate it if you made your code available somewhere via Git (Github, Bitbucket etc.) because SVN sucks ;)

Once you've done that I'll deprecate this library and update the README to point to your library.

adamoutler added a commit to adamoutler/libpitX that referenced this issue Nov 24, 2013
Converting to GPL, assuming ownership, and causing changes to be made available on Github as per conversation with Benjamin Dobell here Benjamin-Dobell#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants