Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] ReactiveSequence not halting children after a running child anymore #810

Closed
afrixs opened this issue Apr 23, 2024 · 2 comments
Closed

Comments

@afrixs
Copy link

afrixs commented Apr 23, 2024

There was recently a backporting update of 3.8 where this line changed from

for (size_t i = index + 1; i < childrenCount(); i++)

to

for (size_t i = 0; i < index; i++)

making ReactiveSequence unable to halt children that were previously running after a child whose state has just switched from SUCCESS to RUNNING. Meanwhile the bug seems to have been fixed in 4.x, but the fix has not been backported to 3.8. Is it possible to backport the fix of this problem as well? Thank you

@facontidavide
Copy link
Collaborator

send a PR please

@afrixs
Copy link
Author

afrixs commented May 10, 2024

I don't dare to make an overall backport merge PR, but #817 is a backport of the particular commit that fixes the problem (+ a small optional defaults-changing commit that keeps the backward compatibility to v3.8.5)

facontidavide added a commit that referenced this issue May 13, 2024
…#817)

* ReactiveSequence and ReactiveFallback will behave more similarly to 3.8

* Reactive Sequence/Fallback defaulting to allow multiple async nodes

---------

Co-authored-by: Davide Faconti <davide.faconti@gmail.com>
Co-authored-by: Matej Vargovcik <vargovcik@robotechvision.com>
@afrixs afrixs closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants