Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making bootstrap button extend android.widget.button #211

Open
greatjack1 opened this issue Nov 1, 2017 · 1 comment
Open

Making bootstrap button extend android.widget.button #211

greatjack1 opened this issue Nov 1, 2017 · 1 comment

Comments

@greatjack1
Copy link

I started using this library to spruce up my app, and I noticed that while most controls just required me to change the xml layout files, the bootstrap button required me to change my controller code since bootstrap button does not extend from android.widget.button. What was the reason for this design decision? and if possible can it be changed?

@fractalwrench
Copy link
Contributor

It extends AwesomeTextView, which in turns extends TextView. This was done as a lot of behaviour such as Bootstrap themes, and Font icons, is common across multiple classes (e.g. BootstrapButton, BootstrapLabel).

BootstrapButton also makes use of some custom touch event logic, which IMO could feel quite confusing to users if the class was extending a regular Android button - as you'd expect it to have the regular Android touch behaviour.

If there are good reasons to change the design of the class then I'm happy to change the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants