Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually overriding which series to use in TiffSlide #23

Open
ap-- opened this issue Mar 21, 2022 · 5 comments
Open

Allow manually overriding which series to use in TiffSlide #23

ap-- opened this issue Mar 21, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@ap--
Copy link
Collaborator

ap-- commented Mar 21, 2022

This came up as a request (initial solution) from #21
While this might usually not required if the default behavior of TiffSlide returns the same series as openslide, it could be an interesting feature in case a user wants to change the default.

I'll have to think about it a bit more, if it's worth supporting this for any format.

@ap-- ap-- added the enhancement New feature or request label Mar 21, 2022
@One-sixth
Copy link
Contributor

One-sixth commented Mar 22, 2022

I give an example. Sometimes the default behavior selects the incorrect series, and manual selection allows us to quickly fix it without having to modify the library code. Because modifying the library code is difficult for some people.

@ap--
Copy link
Collaborator Author

ap-- commented Mar 22, 2022

I completely agree.
I wonder if specifically selecting a series should make TiffSlide fall back to the generic tiff-route though.

Do you have an example of the <scn> xml for a file in which the auto selection fails?

@One-sixth
Copy link
Contributor

I don't have any more examples, because I just learned about and started experimenting with tiffslide last week.

@ap--
Copy link
Collaborator Author

ap-- commented Mar 22, 2022

I just created a new release v1.1.0 with your added support for scn.
Please try that version and if there are cases in which the correct series is not found, we'll work out how to best implement this functionality.

Cheers,
Andreas 😃

@One-sixth
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants