Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python-2-isms and set sharpbang to use 3 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove python-2-isms and set sharpbang to use 3 #21

wants to merge 1 commit into from

Conversation

chadmiller
Copy link

Probably fixes #20

protopyte
protopyte suggested changes Jan 26, 2021
View reviewed changes
Copy link

@protopyte protopyte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 126, tostring() was renamed to tobytes() in python3.2.

Edit: ah sorry, I was commenting from the commit view and didn't see the follow-up discussion.

@kripton
Copy link

kripton commented Apr 5, 2021

Have a look at #28 :)

@chadmiller
Copy link
Author

chadmiller commented Apr 6, 2021 via email

@kripton
Copy link

kripton commented Apr 7, 2021

21 < 28

mathematically correct ;)
what do you want to express?

@cyb3rsad1k0
Copy link

Thank you, @chadmiller. That did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protopyte protopyte protopyte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usb-flash still depends on Python2
5 participants
@chadmiller @kripton @cyb3rsad1k0 @protopyte @yderi