Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "bastille setup" has inconsistent naming and output #671

Open
michael-o opened this issue Jan 29, 2024 · 0 comments
Open

[BUG] "bastille setup" has inconsistent naming and output #671

michael-o opened this issue Jan 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@michael-o
Copy link

michael-o commented Jan 29, 2024

[MANDATORY] Bastille and FreeBSD version (paste bastille -v && freebsd-version -kru output)
0.10.20231125
13.3-PRERELEASE
13.3-PRERELEASE
13.3-PRERELEASE

Inconsistent naming:

bastille0|loopback)
configure_bastille0
;;
zfs|storage)
configure_zfs
;;
bastille1|vnet|bridge)
configure_vnet

The function for the loopback should be named bastille_loopback because the cloned interface for vnet/bridging is named configure_vnet. Naming is inconsistent.

Output of both functions:

info "Configuring bastille0 loopback interface"
sysrc cloned_interfaces+=lo1
sysrc ifconfig_lo1_name="bastille0"
info "Bringing up new interface: bastille0"
service netif cloneup
}

bastille0 name is consistently used the in the output, but
configure_vnet() {
info "Configuring bridge interface"
sysrc cloned_interfaces+=bridge1
sysrc ifconfig_bridge1_name=bastille1
info "Bringing up new interface: bastille1"
service netif cloneup

does not say "Configuring bastille1 bridge interface" while it shouldn't just like for the loopback one.

@michael-o michael-o added the bug Something isn't working label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant