Export ZFS jail give a false error of "Options --gz, --raw, --safe, --verbose are valid for ZFS configured systems only"

[Elektrokongen]

I noticed an false error that prevents me from exporting my ZFS jails. There is a missing ! in the if statement on line 215 in the file /usr/local/share/bastille/export.sh

HERE IS THE CURRENT IF STATEMENT

if checkyesno bastille_zfs_enable; then
if [ -n "${GZIP_EXPORT}" -o -n "${RAW_EXPORT}" -o -n "${SAFE_EXPORT}" -o "${OPT_ZSEND}" = "-Rv" ]; then
error_exit "Options --gz, --raw, --safe, --verbose are valid for ZFS configured systems only."
fi
fi

HERE IS THE FIX I IMPLEMENTED TO GET IT WORKING

if ! checkyesno bastille_zfs_enable; then
if [ -n "${GZIP_EXPORT}" -o -n "${RAW_EXPORT}" -o -n "${SAFE_EXPORT}" -o "${OPT_ZSEND}" = "-Rv" ]; then
error_exit "Options --gz, --raw, --safe, --verbose are valid for ZFS configured systems only."
fi
fi

[Elektrokongen]

I have made an update to the current master, but I need a branch with write rigths in order to commit the update :) I cant seem to find any button on Git that allows me to create a branch..

[JRGTH]

I have made an update to the current master, but I need a branch with write rigths in order to commit the update :) I cant seem to find any button on Git that allows me to create a branch..

I can confirm and validate this small bug as well, Christer will review the PR and merge wen time permits, thanks for the bug report and fix.

PS. You can also use GitHub Desktop Win/Mac, or GitHub Desktop Linux for easy fork/branch creation/deletion/fetch etc.

[Elektrokongen]

I see a fork option yes. I will try that next time, thx 👍

[mgstoyanov]

What's the status of this? I hit the same issue and the fix mentioned seems to work. I don't mind opening a PR for it if that will help speed things up...

[KiriakosGeorgiou]

What's the status of this? I hit the same issue and the fix mentioned seems to work. I don't mind opening a PR for it if that will help speed things up...

I suppose the committers of this fine utility are busy with their jobs like the rest of us :) thanks for the fix to @Elektrokongen so we ZFS users can enjoy no downtime backups.