Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobbling randomly doesn’t work/scrobbling logic doesn’t take into account if server received it #226

Open
el-tiuri opened this issue Mar 12, 2024 · 3 comments
Labels
implemented This feature/bug is implemented

Comments

@el-tiuri
Copy link

Reporting playback to my Subsonic (Navidrome) server randomly doesn’t work; oftentimes the songs at the beginning of a queue or album won’t scrobble, then most of those after will.

I feel like adding a check to see if the server has received the message and resending it if necessary would solve this. I tried diving into the code a while ago to fix scrobling logic (see here: #106 (comment)), but I didn’t end up finding the time to brush up on my skills to resolve this.

I do think that a fix for this would also solve the previous issue;

  • Try to scrobble a song
  • Check if it was received
  • If yes > good
  • If no > cache it with timestamp and retry the next time a scrobble goes through successfully

If I do find the time I’ll try to look at it again myself, but I don’t think that’ll happen tbh.

@BLeeEZ
Copy link
Owner

BLeeEZ commented Apr 22, 2024

Scribble cache is already implemented. When server is not reachable the scrobble gets saved. All cached scrobbles get uploaded when the server is reachable.
I reworked the scrobble behaviour in e4e864c and f427673.

@BLeeEZ BLeeEZ added the implemented This feature/bug is implemented label Apr 22, 2024
@el-tiuri
Copy link
Author

This is fantastic! Are the scrobbles timestamped for the moment they were originally played as described here? That’s the last thing stopping me from using Amperfy full time. I’d test it out myself, but the update isn’t available yet on TestFlight.

Either way, thanks for the improvements!

@BLeeEZ
Copy link
Owner

BLeeEZ commented Apr 23, 2024

Scrobble cache is already available in v1.2.0.
Only the NowPlaying feature is new and can be tested in upcoming v.1.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented This feature/bug is implemented
Projects
None yet
Development

No branches or pull requests

2 participants