Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from using url-parse to native URL library and requiring a polyfill #10

Open
weotch opened this issue Jul 20, 2020 · 0 comments
Open

Switch from using url-parse to native URL library and requiring a polyfill #10

weotch opened this issue Jul 20, 2020 · 0 comments

Comments

@weotch
Copy link
Member

weotch commented Jul 20, 2020 •
edited

https://developer.mozilla.org/en-US/docs/Web/API/URL
weotch referenced this issue Jul 25, 2021
@jonjahr
Pin url-parse to v1.4.0. On my machine, v1.5.0+ broke isInternal by…
3a538cb 
… removing the starting `/` from `urlObj.href`, which caused all relative links to evaluate as external. v1.5.1 also broke `makeRouterPath` by converting `/` links to `/<the current path>`, causing the top nav logo to always point to the current page and do nothing when I clicked on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weotch