Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Version names #139

Open
iknite opened this issue Jun 17, 2019 · 2 comments
Open

Rename Version names #139

iknite opened this issue Jun 17, 2019 · 2 comments

Comments

@iknite
Copy link
Contributor

iknite commented Jun 17, 2019

Proposal:|

ActualVersion -> InsertionVersion (This is the version on the time of writing the event)
CurrentVersion -> TreeVersion (This is the version on the time of the query)
QueryVersion -> QueryVersion (This is the version asked for)

Thoughts?

@gdiazlo
Copy link
Contributor

gdiazlo commented Jun 20, 2019

My proposal:

ActualVersion -> EventIndex
CurrentVerrsion -> ProofIndex
QueryVersion -> QueryIndex

@iknite
Copy link
Contributor Author

iknite commented Jun 26, 2019

Changing Version LGTM to Index, as long as we change every reference of version (and not only this 3 variables)

Using "object names" for temporality (when is stored, and consulted) seems more confusing to me, that's why I've been proposing Insertion. (and this doubt also applies to my TreeVersion proposal)

Just my 2 cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants