Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode digests in APIs and CLI using the same formatting (hexadecimal preferred) #127

Open
jllucas opened this issue May 28, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jllucas
Copy link

jllucas commented May 28, 2019

Digests are of "hashing.Digest" type (byte slice), which get applied a base64 encoding in a json serialization.
The goal is to avoid the base64 encoding.

@gdiazlo
Copy link
Contributor

gdiazlo commented May 29, 2019

I think we need to implement marshalers and unmarshalers to our data types, so they get encoded as we want, instead of using the default rules of the json package.

@gdiazlo gdiazlo added the enhancement New feature or request label May 29, 2019
@gdiazlo gdiazlo changed the title Json serialize digests from protocol.Snapshot as string Encode digests in APIs and CLI using the same formatting (hexadecimal preferred) May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants