Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Non reported breaking change on 4.61.0 #4768

Closed
azchohfi opened this issue May 15, 2024 · 0 comments · Fixed by #4767
Closed

[Bug] Non reported breaking change on 4.61.0 #4768

azchohfi opened this issue May 15, 2024 · 0 comments · Fixed by #4767

Comments

@azchohfi
Copy link

azchohfi commented May 15, 2024

Library version used

4.61.0

.NET version

net8.0-windows10.0.17763.0

Scenario

PublicClient - desktop app

Is this a new or an existing app?

The app is in production, and I have upgraded to a new version of MSAL

Issue description and reproduction steps

Upgrading to non-major versions of MSAL.Net should not have breaking changes, and 4.61.0 had a breaking change.

Upgrading to 4.61.0, we then got this reported:
microsoft/msstore-cli#38

The release notes made no mention of this, and since it was a non-major version, this seemed safe to upgrade. We only have unit tests in our project, so we didn't get this in our builds.

Relevant code snippets

My code was basically:

using Microsoft.Identity.Client;
using Microsoft.Identity.Client.Extensions.Msal;
...
var app = PublicClientApplicationBuilder
    .Create(ClientId)
    .WithDefaultRedirectUri()
    .WithBroker()
    .WithParentActivityOrWindow(Helpers.NativeMethods.GetConsoleOrTerminalWindow)
    .Build();

That was using the Boolean overload of the WithBroker method.

Expected behavior

No breaking change!

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

4.60.3

Solution and workarounds

Actually upgrade to 4.61.0:
microsoft/msstore-cli@9bf51e9

@azchohfi azchohfi added needs attention Delete label after triage untriaged Do not delete. Needed for Automation labels May 15, 2024
@bgavrilMS bgavrilMS added bug P2 public-client and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels May 15, 2024
@bgavrilMS bgavrilMS self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants