Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the e2e workflow to use the Makefile targets to setup kind cluster and run tests #353

Open
nitishm opened this issue Jul 3, 2021 · 0 comments
Labels
chore Chores

Comments

@nitishm
Copy link
Contributor

nitishm commented Jul 3, 2021

Currently we are using the old way of creating the kind cluster i.e.

      - name: Create k8s Kind Cluster
        uses: engineerd/setup-kind@v0.5.0
        with:
          version: "v0.9.0"
          name: orkestra
          wait: 10s
          config: .kind-cluster.yaml
      - name: Deploy
        run: |
          curl https://baltocdn.com/helm/signing.asc | sudo apt-key add -
          sudo apt-get install apt-transport-https --yes
          echo "deb https://baltocdn.com/helm/stable/debian/ all main" | sudo tee /etc/apt/sources.list.d/helm-stable-debian.list
          curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"  | bash
          sudo apt-get update
          sudo apt-get install helm
          kind export kubeconfig --name orkestra
          helm install orkestra chart/orkestra --wait --atomic -n orkestra --create-namespace --values chart/orkestra/values-ci.yaml
      - name: Verify Deployment
        run: |
          curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
          chmod +x kubectl
          sudo mv kubectl /usr/local/bin
          kubectl cluster-info
          echo "current-context:" $(kubectl config current-context)

We should switch over to the Makefile targets that we use in our development workflow instead to mimic what contributors will use for local testing, i.e

make clean
make dev
make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores
Projects
None yet
Development

No branches or pull requests

1 participant