Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application namespaces should be created only by the controller since the ApplicationGroup owns each of the created resources #291

Open
nitishm opened this issue Jun 8, 2021 · 2 comments
Labels
chore Chores size : S Byte size tasks
Projects
Milestone

Comments

@nitishm
Copy link
Contributor

nitishm commented Jun 8, 2021

Currently, the namespace creation is duplicated in both the reconciler and the executor container. It would be better to have the reconciler create the namespace while ignoring 'Already Exists' errors.

Additionally, in keeping with helm client's --create-namespace option, the created namespace should also be labeled with

labels:
  name: <namespace>
@nitishm nitishm added the feat Feature label Jun 8, 2021
@nitishm nitishm changed the title Add metadata label name=<namespace-name> to the namespace(s) created by Orkestra Application namespaces should be created only by the controller since the ApplicationGroup owns each of the created resources Jun 8, 2021
@nitishm nitishm added bug Something isn't working and removed feat Feature labels Jun 8, 2021
@nitishm
Copy link
Contributor Author

nitishm commented Jun 8, 2021

/cc @jonathan-innis @mgl1969

@nitishm
Copy link
Contributor Author

nitishm commented Jun 9, 2021

For reference, the two places where this happens currently are,

Orkestra:
https://github.com/Azure/orkestra/blob/main/pkg/workflow/argo.go#L121-L133

Workflow Executor:
https://github.com/Azure/orkestra-workflow-executor/blob/main/main.go#L116-L136

@nitishm nitishm added this to To Do in Orkestra Jun 14, 2021
@nitishm nitishm added chore Chores size : S Byte size tasks and removed bug Something isn't working labels Jun 14, 2021
@nitishm nitishm added this to the Milestone #2 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores size : S Byte size tasks
Projects
Orkestra
  
To Do
Development

Successfully merging a pull request may close this issue.

1 participant