Validate relationship field names in config as backing columns #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
mbhaskar,
Aniruddh25,
seantleonard,
Mathos1432,
gledis69,
tarazou9,
ayush3797,
abhishekkumams,
aaronpowell,
severussundar,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
seantleonard
requested changes
Apr 25, 2024
src/Service.Tests/SqlTests/GraphQLQueryTests/DwSqlGraphQLQueryTests.cs
Outdated
Show resolved
Hide resolved
… of https://github.com/Azure/data-api-builder into dev/aaronburtle/RelationshipValidationOnBackingColumns
|
/azp run |
|
/azp run |
|
/azp run |
seantleonard
added a commit
that referenced
this pull request
Apr 29, 2024
seantleonard
approved these changes
Apr 30, 2024
|
/azp run |
ayush3797
deleted the
dev/aaronburtle/RelationshipValidationOnBackingColumns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2166
Related to #2139
What is this change?
When we validate the relationship fields in the config, ie: source fields and target fields, we use the backing column names to validate against. Previously we were using aliases if one existed, but instead we will validate only against the actual names of the backing columns. So, for example, if someone had an alias for the column "id", so that it would display as "identifier" when using this alias, we would validate that the relationship defined with that field was defined in the config using the name "id", and would throw a validation error if the config instead used, "identifier."
How was this tested?
Current test suite passing, along with a regression test for DwSql, MsSql, MySql, and PostreSql.
Sample Request(s)
Please see this issue for details on samples to reproduce.
#2166