Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if DbType is required, since now we are introducing SqlDbType #2128

Open
abhishekkumams opened this issue Mar 22, 2024 · 1 comment
Open

Check if DbType is required, since now we are introducing SqlDbType #2128

abhishekkumams opened this issue Mar 22, 2024 · 1 comment
Labels
refactor

Comments

@abhishekkumams
Copy link
Contributor 

          Bloating a ParamDefinition/ColumnDefinition with fields not relevant for every database seems not to be the best approach here.

Originally posted by @ayush3797 in #2052 (comment)
@abhishekkumams abhishekkumams mentioned this issue Mar 22, 2024
Merged
@seantleonard
Copy link
Contributor

Need more context for this issue. Which database use the param/column definition types? SqlDbType is only applicable to MSSQL and not pg/mysql/cosmos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seantleonard @abhishekkumams