Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default data source name for Hot Reload #1967

Closed
Tracked by #67
aaronburtle opened this issue Jan 12, 2024 · 2 comments · Fixed by #2069 · May be fixed by #1981
Closed
Tracked by #67

Change default data source name for Hot Reload #1967

aaronburtle opened this issue Jan 12, 2024 · 2 comments · Fixed by #2069 · May be fixed by #1981
Assignees
@aaronburtle
Labels
refactor
Milestone
0.12rc

Comments

@aaronburtle
Copy link
Contributor

We are currently assigning a unique default data source name to each RuntimeConfig that we create. However, for a Hot Reload scenario this is problematic because we do not want to be updating this value after the Hot Reload, and so, it can not be uniquely generated each time.

Instead this value should be created in a deterministic way, ie: taking a hash of the connection string.
@aaronburtle aaronburtle added this to the 0.11rc milestone Jan 12, 2024
@aaronburtle aaronburtle self-assigned this Jan 12, 2024
@aaronburtle aaronburtle mentioned this issue Jan 12, 2024
Open
@aaronburtle aaronburtle linked a pull request Jan 24, 2024 that will close this issue
Refactor RuntimeConfig into Interface with Local and Hosted Providers #1981
Open
@aaronburtle aaronburtle mentioned this issue Jan 24, 2024
Open
@Aniruddh25 Aniruddh25 modified the milestones: 0.11rc, 0.12rc Feb 28, 2024
@aaronburtle aaronburtle mentioned this issue Mar 2, 2024
Merged
1 task
@seantleonard
Copy link
Contributor

because we do not want to be updating this value after the Hot Reload

need to explain why in the issue so motivation behind this change is clear.

@seantleonard
Copy link
Contributor

Not moving this task at the moment, this fix seems necessary even without remaining HR features in this milestone.

aaronburtle added a commit that referenced this issue Mar 13, 2024
@aaronburtle
Maintain Default Data Source Name from Original Config after Hot Relo…
40142af 
…ading (#2069)

## Why make this change?

Closes #1967

We maintain the same default data source name after hot reloading.

## What is this change?

When hot reloading, pass along the original default data source name,
and after creating the runtimeconfig object, update that name and the
dependent data structures to use the original data source name from
before the hot reload.

## How was this tested?

- [ ] Unit Tests
Added validation that we maintain the same default data source name to
the unit tests.


## Sample Request(s)

- Example REST and/or GraphQL request to demonstrate modifications
- Example of CLI usage to demonstrate modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronburtle aaronburtle

Labels
refactor
Projects
None yet
Milestone
0.12rc
3 participants
@Aniruddh25 @seantleonard @aaronburtle