You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current design utilizes a single RuntimeConfiProvider class to provide access to the RuntimeConfig, which this class currently stores internally. This refactor will break the RuntimeConfigProvider into separate classes for local and hosted scenarios, which both implement a common interface. Instead of storing the RuntimeConfig within the providers, we will store them in the RuntimeConfigLoader classes. For the hosted scenario, we are not immediately implementing hot reloading and so the HostedRuntimeConfigProvider may still store a RuntimeConfig internally until we have a separate HostedConfigLoader to handle the hosted scenario.
This also requires refactoring to correctly utilize each kind of provider, and also to properly register these various classes during initialization.
The text was updated successfully, but these errors were encountered:
aaronburtle
changed the title
Refactor RuntimeConfigProvider to be more Extensible for Hot Reloading
Refactor RuntimeConfigProvider to be more extensible for Hot Reloading
Jan 12, 2024
Moving some hot reload tasks to backlog so we can focus on tasks that add hotreload support various services/classes (openapi, authentication config). Once the pre-reqs are done, it will be easier to start updating the runtime config classes directly.
The current design utilizes a single
RuntimeConfiProvider
class to provide access to theRuntimeConfig
, which this class currently stores internally. This refactor will break theRuntimeConfigProvider
into separate classes for local and hosted scenarios, which both implement a common interface. Instead of storing theRuntimeConfig
within the providers, we will store them in theRuntimeConfigLoader
classes. For the hosted scenario, we are not immediately implementing hot reloading and so theHostedRuntimeConfigProvider
may still store aRuntimeConfig
internally until we have a separateHostedConfigLoader
to handle the hosted scenario.This also requires refactoring to correctly utilize each kind of provider, and also to properly register these various classes during initialization.
The text was updated successfully, but these errors were encountered: