Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RuntimeConfigProvider to be more extensible for Hot Reloading #1966

Open
Tracked by #67
aaronburtle opened this issue Jan 12, 2024 · 2 comments · May be fixed by #1981
Open
Tracked by #67

Refactor RuntimeConfigProvider to be more extensible for Hot Reloading #1966

aaronburtle opened this issue Jan 12, 2024 · 2 comments · May be fixed by #1981
Assignees
Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal refactor
Milestone

Comments

@aaronburtle
Copy link
Contributor

The current design utilizes a single RuntimeConfiProvider class to provide access to the RuntimeConfig, which this class currently stores internally. This refactor will break the RuntimeConfigProvider into separate classes for local and hosted scenarios, which both implement a common interface. Instead of storing the RuntimeConfig within the providers, we will store them in the RuntimeConfigLoader classes. For the hosted scenario, we are not immediately implementing hot reloading and so the HostedRuntimeConfigProvider may still store a RuntimeConfig internally until we have a separate HostedConfigLoader to handle the hosted scenario.

This also requires refactoring to correctly utilize each kind of provider, and also to properly register these various classes during initialization.

@aaronburtle aaronburtle added this to the 0.11rc milestone Jan 12, 2024
@aaronburtle aaronburtle self-assigned this Jan 12, 2024
@aaronburtle aaronburtle changed the title Refactor RuntimeConfigProvider to be more Extensible for Hot Reloading Refactor RuntimeConfigProvider to be more extensible for Hot Reloading Jan 12, 2024
@seantleonard seantleonard modified the milestones: 0.11rc, 0.12rc Feb 13, 2024
@seantleonard seantleonard modified the milestones: 0.12rc, 1.2rc Mar 7, 2024
@seantleonard
Copy link
Contributor

Moving this + hot reload related tasks to post GA -> tracking via 1.2rc milestone.

The current PR can be moved to draft or closed for the time being until we revisit this feature post-GA.

@seantleonard seantleonard added the 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal label May 14, 2024
@seantleonard seantleonard modified the milestones: 1.2rc, Feature Backlog May 17, 2024
@seantleonard
Copy link
Contributor

Moving some hot reload tasks to backlog so we can focus on tasks that add hotreload support various services/classes (openapi, authentication config). Once the pre-reqs are done, it will be easier to start updating the runtime config classes directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants