Device Login Track-2 Migration #2574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavmalik-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
tasherif-msft and
seanmcc-msft
as code owners
gapra-msft
reviewed
Feb 14, 2024
|
This should be made a draft till we finalize the token persistence |
|
Open question - how will we test this? @adreed-msft any ideas? Look into how Identity tests this. |
…ttps://github.com/Azure/azure-storage-azcopy into pranavmalik/personal/device_login_track2migration
The idea for testing was that we'd have semi-automated tests in a E2E suite. Stick the suite behind a build tag (preventing it from running in CI), something like "manualinteraction", run azcopy login at the suite setup, run logout at suite teardown. I'd already given a little guidance in a 1:1 with Pranav. |
|
Can we close this PR in favor of the other one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to facilitate the migration process from the existing ADAL library to the MSAL framework, specifically for device login functionalities.
Changes