Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include system affinity for when ASO runs on AKS #3828

Open
theunrepentantgeek opened this issue Feb 27, 2024 · 2 comments
Open

Include system affinity for when ASO runs on AKS #3828

theunrepentantgeek opened this issue Feb 27, 2024 · 2 comments

Comments

@theunrepentantgeek
Copy link
Member

Describe the improvement

A suggestion made via email:

My suggestion to improve ASO would be to include the following node affinity block that would target system nodepools on any AKS cluster:

affinity:
    nodeAffinity:
        requiredDuringSchedulingIgnoredDuringExecution:
          nodeSelectorTerms:
          - matchExpressions:
            - key: kubernetes.azure.com/mode
              operator: In
              values:
                - system

According to @matthchr we shouldn't use required because it ASO is supported on non AKS clusters, but there's a preferredDuringSchedulingIgnoredDuringExecution we could use too.

@matthchr
Copy link
Member

matthchr commented Mar 4, 2024

What do we have set for mem/cpu requirements - are they too low?

@matthchr
Copy link
Member

matthchr commented Mar 4, 2024

We may need a negative assertion rather than positive: "Don't schedule on the user pool", rather than "must schedule on the system pool"

and wahtever we do should probably be put in a Helm "if" block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants