Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board Review: Management Plane Namespace Review SplitIOExperimentation #7440

Closed
hahahahahaiyiwen opened this issue Apr 11, 2024 · 12 comments
Closed
Assignees
Labels
architecture board-review Request for an Architectural Board Review mgmt-namespace-ready Approve the namespace review request of mgmt plan SDK mgmt-namespace-review requests for namespace reviews of mgmt plane SDKs

Comments

@hahahahahaiyiwen
Copy link
Member

hahahahahaiyiwen commented Apr 11, 2024

Thank you for submitting this review request. Thorough review of your management library namespaces ensures that your library names are consistent with the guidelines and the consumers of your management library have a consistently good experience when using Azure.

To ensure consistency, all language library names will generally be reviewed together.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

  • Responsible service team: Liftr-Split
  • Main contacts: ernestt@microsoft.com
  • Expected code complete date: Nov 2024
  • Expected release date: Nov 2024

About the Service (required)

Namespace Proposals (required per language)

In the examples below please replace every occurrence of [ResourceProviderName] with your the service resource provider name. Be sure to keep the casing shown with [ResourceProviderName] when replacing it with the service resource provider name.

  • .NET: Azure.ResourceManager.SplitIOExperimentation
  • Java: azure-resourcemanager-splitioexperimentation (com.azure.resourcemanager.splitioexperimentation)
  • Go/Golang: sdk/resourcemanager/splitioexperimentation/armsplitioexperimentation
  • JavaScript: @azure/arm-splitioexperimentation
  • Python: azure-mgmt-splitioexperimentation

Thank you!

@hahahahahaiyiwen hahahahahaiyiwen added architecture board-review Request for an Architectural Board Review mgmt-namespace-review requests for namespace reviews of mgmt plane SDKs labels Apr 11, 2024
@ronniegeraghty
Copy link
Member

@hahahahahaiyiwen, please remove all [ and ] from the namespaces. They were supposed to be removed when you replaced [ResourceProviderName].

@hahahahahaiyiwen
Copy link
Member Author

@ronniegeraghty updated.

@hahahahahaiyiwen
Copy link
Member Author

@ronniegeraghty The API spec PR is completed and now available in public repo https://github.com/Azure/azure-rest-api-specs/blob/main/specification/splitio/resource-manager/SplitIO.Experimentation/preview/2024-03-01-preview/splitio.json.

Is there any other open items that requires actions on our side?

@ArthurMa1978
Copy link
Member

Hey @hahahahahaiyiwen, one question: why retain the ‘IO’ suffix as the company’s name is ‘Split’ and ‘IO’ merely represents the domain?

@hahahahahaiyiwen
Copy link
Member Author

@ArthurMa1978 , we discussed this with Split when deciding our resource provider namespace "SplitIO.Experimentation", and Split wants to present their name in namespaces as "SplitIO". To be consistent, we want to use "SplitIO" instead of "Split" in SDK namespaces as well.

@ArthurMa1978
Copy link
Member

Got it, thank you @hahahahahaiyiwen.
Then the namespace is good to me.

@ArthurMa1978 ArthurMa1978 added the mgmt-namespace-ready Approve the namespace review request of mgmt plan SDK label May 7, 2024
@ronniegeraghty
Copy link
Member

ronniegeraghty commented May 7, 2024

Now that Arthur has given approval, we'll move on to getting the architects approval. As I mentioned we normally show the architects the proposed namespaces then wait a week to see if any of them raise any objections For this review I'll also see if we can get specific approval from each language to possible close the review faster. At the latest the review should be concluded by EoD on 5/14 if there are no objections. Once the names are approved I'll leave another comment on the issue stating so and close it out.

@ronniegeraghty
Copy link
Member

Hi @hahahahahaiyiwen,
I was able to get explicit approvals from an architect from each language. The namespaces in the description of this issue are now considered approved.

@hahahahahaiyiwen
Copy link
Member Author

Will the namespace now show in the Azure SDK Release Planner? @ronniegeraghty

@ronniegeraghty
Copy link
Member

I am not sure if the release planner will automatically pick up on the namespaces mentioned in this issue, or if the release planner will pick up on the closing of this issue as the review being completed. @ladonnaq or @maririos, would either of you know the answer to that question?

I do know that when our Mgmt Plane team looks to confirm the approval of your namespaces, they will see this issue and see that they were approved.

@ladonnaq
Copy link
Member

ladonnaq commented May 9, 2024

I am not sure if the release planner will automatically pick up on the namespaces mentioned in this issue, or if the release planner will pick up on the closing of this issue as the review being completed. @ladonnaq or @maririos, would either of you know the answer to that question?

I do know that when our Mgmt Plane team looks to confirm the approval of your namespaces, they will see this issue and see that they were approved.

There was a miscommunication between the SDK management plane team and Release Planner App team. The SDKs for management plane are not generated by our management plane team until later in the SDK release milestone workflow. The Release Planner App engineering team is working on a "hot fix" to resolve. I have requested that engineering manually if needed so that you are not blocked from requesting the generation and release of the SDKs by the monthly 2nd Friday cutoff (tomorrow).

@ladonnaq
Copy link
Member

ladonnaq commented May 9, 2024

@hahahahahaiyiwen - We were able to generate the SDKs for you so that the namespace will show-up in the drop-down box for you. You should be unblocked and able to request SDKs before the monthly 2nd Friday cutoff. If you need help you can post questions to the Azure SDK Onboarding Teams channel - https://aka.ms/azsdk/onboarding-channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review mgmt-namespace-ready Approve the namespace review request of mgmt plan SDK mgmt-namespace-review requests for namespace reviews of mgmt plane SDKs
Projects
None yet
Development

No branches or pull requests

5 participants