Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure SDK Review - [Azure Identity] #7336

Open
azure-sdk opened this issue Mar 13, 2024 · 4 comments
Open

Azure SDK Review - [Azure Identity] #7336

azure-sdk opened this issue Mar 13, 2024 · 4 comments
Labels
needs-triage This is a new issue that needs to be triaged to the appropriate team.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 13, 2024

New SDK Review meeting has been requested.

Service Name: Azure Identity
Review Created By: Bill Wert
Review Date: 03/26/2024 02:05 PM PT

Release Plan:
Hero Scenarios Link: Not Provided
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: C++, Javascript, .NET, Go/Golang, Java, Python,

Description:
Identity plans to GA in April with one small feature enabling defaulting to the signed on user account for broker scenarios. This should be a short review.

Detailed meeting information and documents provided can be accessed here

@github-actions github-actions bot added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Mar 13, 2024
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Bill Wert

Service Name: Azure Identity
Review Created By: Bill Wert
Review Date: 03/26/2024 02:05 PM PT

Hero Scenarios Link: Not Provided
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: C++, Javascript, .NET, Go/Golang, Java, Python,

Description: Identity plans to GA in April with one small feature enabling defaulting to the signed on user account for broker scenarios. This should be a short review.

Detailed meeting information and documents provided can be accessed here

@billwert
Copy link

billwert commented Mar 22, 2024

APIViews:

Java:
azure-identity: https://apiview.dev/Assemblies/Review/8c9c1c6c93ea4f298c02777645554146/0a5238ea5e354882b652c8b65ad2b13c?diffRevisionId=8183884b5edf408abb9989154b54d655&doc=False&diffOnly=True
azure-identity-broker: https://apiview.dev/Assemblies/Review/cde5edd88a584bd2956c1d2ba82170a9/6e75a5cd1daf4214bb79c658c511471c?diffRevisionId=946cf4a13cf04c56890f0fac9d2f2e46&doc=False&diffOnly=True

Javascript:
azure/identity
https://apiview.dev/Assemblies/Review/c49af6b672aa421f93f0a3f22964736d/8367316fb48746a48059092c19a23490?diffRevisionId=adb6ff1fb84846bebaca951e2ab405e7&doc=False&diffOnly=True

Note: JS changes are only in the azure/identity library. The broker package didn't have any surface area changes.

Python:
azure-identity: https://apiview.dev/Assemblies/Review/f020a2e326444ae2acc406846e39dc48/1e175d7adac84f2da8b36d8fb933b22f?diffRevisionId=54eed97f40ce43dfa6b291cb40c57cc6&doc=False&diffOnly=True

azure-identity-broker:
https://apiview.dev/Assemblies/Review/9ea0571110bf4cb09f59d4efcd759ce6/f31b6b9a5d77401c9ae5fe021a5b0739?diffRevisionId=025cfc78ed434956b877c9c83b4bc9eb&doc=False&diffOnly=True

.NET:
Azure.Identity: https://apiview.dev/Assemblies/Review/23780d4899e0495c849f64e0aecfd2e9/2de032d7f4ed428ab93f1e918853ecf1?diffRevisionId=6b93ffc8b4424d2bb81a30c79b9d7837&doc=False&diffOnly=True

Azure.Identity.Broker:
https://apiview.dev/Assemblies/Review/e47b0dcb1d31411583ebd476b90d49e9?revisionId=22447269f236405d93e2b9093912f653&diffRevisionId=5641ac68ddef42a98f58cc0cbe9af216

@annatisch
Copy link
Member

The Python APIview is not Python...

@billwert
Copy link

The Python APIview is not Python...

Apologies, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

No branches or pull requests

3 participants