Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuppressionReviewRequired should only be added to PRs that add suppressions #8231

Open
heaths opened this issue May 8, 2024 · 0 comments
Open

SuppressionReviewRequired should only be added to PRs that add suppressions #8231

heaths opened this issue May 8, 2024 · 0 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@heaths
Copy link
Member

heaths commented May 8, 2024

I'm not sure exactly how suppressions are determined to require a review, but it seems PRs shouldn't be blocked if they don't add any new suppressions. Maybe a new baseline has to be set - especially if a service already GA'd.

E.g., Azure/azure-rest-api-specs#28841
@heaths heaths added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label May 8, 2024
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label May 20, 2024
@konrad-jamrozik konrad-jamrozik self-assigned this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🐬🛥️☀️😎
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heaths @konrad-jamrozik