Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK does not provide means of getting Next Page of Subscription Aliases #29469

Open
2 of 6 tasks
StevenWolfeCAI opened this issue Apr 26, 2024 · 8 comments
Open
2 of 6 tasks
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention This issue needs attention from Azure service team or SDK team no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. Subscription

Comments

@StevenWolfeCAI
Copy link

  • Package Name: @azure/arm-subscriptions
  • Package Version: 5.1.0
  • Operating system:
  • nodejs
    • version: v20
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
When using the SDK to retrieve a list of Subscription Aliases there is no SDK means or documentation provided on getting anything beyond the first page.

To Reproduce
Steps to reproduce the behavior:

  1. Use the SDK to try to retrieve more than one page of Subscription Aliases

Expected behavior
The SDK should support functions to retrieve additional pages, if nextLink is present and populated.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
We have opened support tickets previously and verified this is not currently supported. We prefer not to "roll our own".

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 26, 2024
@jeremymeng jeremymeng added Mgmt This issue is related to a management-plane library. Subscription and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Apr 26, 2024
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label Apr 26, 2024
@kazrael2119
Copy link
Contributor

will check

@kazrael2119
Copy link
Contributor

Hi @StevenWolfeCAI
JS SDK is generated from swagger, in swagger ,it is not support paging now.
I tried to support paging locally and regenerated the sdk, here is the package:
azure-arm-subscriptions-5.2.0.zip
could you use this package and try again?

And add Service Attention label in this issue

@kazrael2119 kazrael2119 added Service Attention This issue is responsible by Azure service team. needs-author-feedback More information is needed from author to address the issue. and removed needs-team-attention This issue needs attention from Azure service team or SDK team labels Apr 28, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anuragdalmia @ramaganesan-rg @ShilpiGautam.

Copy link

Hi @StevenWolfeCAI. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@searles9
Copy link

searles9 commented May 2, 2024

Hi @StevenWolfeCAI , JS SDK is generated from swagger, in swagger ,it is not support paging now. I tried to support paging locally and regenerated the sdk, here is the package: azure-arm-subscriptions-5.2.0.zip could you use this package and try again?

And add Service Attention label in this issue

@kazrael2119 Can you elaborate on how to page over the results using this new change you implemented?

The alias.list() call returns {value: x, nextLink: x}.... how do you then take the next link and get the next page?
Does nextlink get passed as a param ? Do I need to attach it as a custom header in the list call? Is the function now returning an async iterator?

What change did you make?

cc: @anuragdalmia @ramaganesan-rg @ShilpiGautam.

@qiaozha
Copy link
Member

qiaozha commented May 6, 2024

it's not on the customer side, service team need to add a x-ms-pagable in the operation link that @kazrael2119 shared.

@searles9
Copy link

searles9 commented May 6, 2024

it's not on the customer side, service team need to add a x-ms-pagable in the operation link that @kazrael2119 shared.

Can you elaborate? On the customer side how does the customer (me) get all of the results of the alias.list() sdk method?
Are you suggesting that adding x-ms-pagable means if I call alias.list() with no parameters that I will get all results (because paging is handled internally), and there is no action that needs to be taken to loop through each page of results?

Copy link

Hi @StevenWolfeCAI, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 13, 2024
@qiaozha qiaozha removed the needs-author-feedback More information is needed from author to address the issue. label May 15, 2024
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention This issue needs attention from Azure service team or SDK team no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. Subscription
Projects
None yet
Development

No branches or pull requests

5 participants