Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[notification hubs] Unable to create an FCM v1 notification body or FCM legacy notification body #29465

Closed
2 of 6 tasks
bm77525-kr opened this issue Apr 26, 2024 · 2 comments
Closed
2 of 6 tasks

[notification hubs] Unable to create an FCM v1 notification body or FCM legacy notification body #29465

bm77525-kr opened this issue Apr 26, 2024 · 2 comments
Assignees
@mpodwysocki
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Notification Hub question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.

Comments

@bm77525-kr
Copy link

  • Package Name: @azure/notificaiton-hubs
  • Package Version: 1.2.1
  • Operating system: macOS
  • nodejs
    • version: 18
  • browser
    • name/version:
  • typescript
    • version: 5.3
  • Is the bug related to documentation in

Describe the bug
This PR #29422 was merged to fix #29404 which was an issue with the FCMv1 notification body type. However, the new FirebaseV1NativeMessageEnvelope was applied to the function signature of the legacy FCM utility function createFirebaseLegacyNotificationBody and not the FCMv1 utility function. createFirebaseV1NotificationBody remains as unusable as it was in #29404 and now createFirebaseLegacyNotificationBody is also broken since it's expecting the wrong type.

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to create a valid legacy firebase notification body using an object with createFirebaseLegacyNotificationBody
  2. Observe an invalid type error
  3. Attempt to create a valid FCMv1 notification body using an object with createFirebaseV1NotificationBody
  4. Observe an invalid type error (same issue as [notification hubs] Unable to create an FCM v1 notification body using an object #29404).

Expected behavior
I can create a valid notification body for FCMv1 and Firebase Legacy using createFirebaseV1NotificationBody and createFirebaseLegacyNotificationBody.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Notification Hub question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. labels Apr 26, 2024
@github-actions GitHub Actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @tjsomasundaram.

@mpodwysocki mpodwysocki mentioned this issue Apr 29, 2024
Merged
3 tasks
mpodwysocki added a commit that referenced this issue Apr 29, 2024
@mpodwysocki
[notification-hubs] Fix FCMV1 bugs (#29507)
e905eaf 
### Packages impacted by this PR

- @azure/notification-hubs

### Issues associated with this PR

- #29465

### Describe the problem that is addressed by this PR

Fixes the right signatures for the FCM versus FCM Legacy.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
@mpodwysocki
Copy link
Contributor

Closed by e905eaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpodwysocki mpodwysocki

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Notification Hub question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpodwysocki @bm77525-kr