-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix move to next page in paged response #5625
Conversation
FWIW, here is what code our current codegen would generate for pageable:
I didn't find a private constructor there, but the codegen is essentially doing the same by doing this: ListPagedResponse response{};
response.m_client = std::make_shared<PageableClient>(*this);
response.m_options = options; I am not proposing that you necessarily should remove the constructor, but I am more making an argument for the construction being private. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if there is someone knowledgeable who is supposed to ok this PR, and I do not know if you resolved the other feedback from other team members in this PR, and if they are happy, but the part that I more or less understand and commented on, looks good now :)
closes #5617
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.