Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft Azure Data Manager for Agriculture - Microsoft Azure Data Manager for Agriculture] API Review #28833

Open
azure-sdk opened this issue Apr 24, 2024 · 1 comment · May be fixed by #28646
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: Microsoft Azure Data Manager for Agriculture - Microsoft Azure Data Manager for Agriculture
Review Created By: Abhishek Khatri
Review Date: 05/08/2024 09:00 AM PT
Release Plan:
PR: #28646
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: Feedback for New Api Version

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Apr 24, 2024
@azure-sdk azure-sdk linked a pull request Apr 24, 2024 that will close this issue
3 tasks
@mikekistler
Copy link
Member

Notes from API Review 5/8/24

  • Large breaking change
  • Need to update the descriptions on the new endpoints
  • solutions:create-job - send a request to a solution and get the response
    • Returns a 202 -- response body should be a status monitor
  • Some concern about custom authorization mechanisms
  • Response is just type: object -- customers must access solution API definitions to know the shape of the response
  • Some of these APIs will be replaced with Fabric APIs before GA
    • Catalogs, Collections, Items, Schemas (check?) will GA, rest will remain in preview and eventually drop
    • All these were reviewed previously
  • We won't review the non-GA endpoints in detail as they'll be dropped

This API (the parts targeted for eventual GA) looks fine for preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

2 participants