Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-existant coordinatorServerEdition in DBforPostgreSQL examnples #28826

Open
thomas11 opened this issue Apr 24, 2024 · 6 comments
Open
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue points to a problem in the management-plane of the library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@thomas11
Copy link

API Spec link

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/postgresqlhsc/resource-manager/Microsoft.DBforPostgreSQL/stable/2022-11-08/examples/ClusterCreateBurstablev2.json#L15

API Spec version

2022-11-08

Describe the bug

Examples ClusterCreateBurstablev1.json and ClusterCreateBurstablev2.json have the line

"coordinatorServerEdition": "BurstableGeneralPurpose",

However, no such edition exists. az postgres server list-skus --location westus doesn't list it and the spec doesn't mention it anywhere.

Expected behavior

The examples work out of the box.

Actual behavior

The examples fail with

There is no valid SKU with given coordinator server edition ("BurstableMemoryOptimized") and vCores (1).

Reproduction Steps

Make a request to create a Cluster with the ClusterCreateBurstablev1.json or ClusterCreateBurstablev2.json payloads.

Environment

No response

@thomas11 thomas11 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 24, 2024
@zzhxiaofeng zzhxiaofeng added the Mgmt This issue points to a problem in the management-plane of the library. label Apr 24, 2024
@zzhxiaofeng
Copy link
Member

@senatol Please help have a look, thank you.

@senatol
Copy link
Member

senatol commented Apr 30, 2024

Hello @thomas11!

The Azure CLI commands for working with the “Azure Cosmos DB for PostgreSQL” service, as you referred to, are az cosmosdb postgres .... The command you mentioned, az postgres server list-skus --location westus, belongs to the “Azure Database for PostgreSQL” service. Azure Cosmos DB for PostgreSQL service does not have a “list-skus” command.

For the example payloads, thank you for reporting the issue. I was able to reproduce the error with ClusterCreateBurstablev1.json example. I will make sure to include the fix in the next deployment with ETA ~1 month. In the meantime, you may use Azure Portal to create Burstable cluster with 1 vCores.

For the second example, the payload seems correct and worked for me. Could you please try again with ClusterCreateBurstablev2.json example and let me know?

@senatol
Copy link
Member

senatol commented May 2, 2024

Hello again @thomas11,

Could you please share the request payload for which you've received the following error?

There is no valid SKU with given coordinator server edition ("BurstableMemoryOptimized") and vCores (1).

The reason I'm asking is the error I received while testing the ClusterCreateBurstablev1.json example payload is the following, which is different than yours:

There is no valid SKU with given worker server edition ("MemoryOptimized") and vCores (1).

But I was not able to reproduce your error with coordinator server edition and I'd like to understand your steps.

@thomas11
Copy link
Author

thomas11 commented May 6, 2024

Hi @senatol!

This is the exact payload we were sending:

    {
        "location": "westus",
        "properties": {
            "administratorLoginPassword": "Fooooooo11",
            "citusVersion": "11.3",
            "coordinatorEnablePublicIpAccess": true,
            "coordinatorServerEdition": "BurstableMemoryOptimized",
            "coordinatorStorageQuotaInMb": 524288,
            "coordinatorVCores": 2,
            "enableHa": false,
            "enableShardsOnCoordinator": true,
            "nodeCount": 0,
            "postgresqlVersion": "15",
            "preferredPrimaryZone": "2"
        }
    }

As a PUT request to /subscriptions/REDACTED/resourceGroups/REDACTED/providers/Microsoft.DBforPostgreSQL/serverGroupsv2/laci-test-cluster?api-version=2022-11-08.

I think it matches Azure's example exactly.

@senatol
Copy link
Member

senatol commented May 7, 2024

Hello @thomas11 ,

The payload you provided has "coordinatorVCores": 2 with "coordinatorServerEdition": "BurstableMemoryOptimized" which doesn't point to any SKU for Azure Cosmos DB for PostgreSQL.

  1. For BurstableMemoryOptimized, supported coordinatorVCores is 1
  2. For BurstableGeneralPurpose, supported coordinatorVCores is 2

Please note that when you try the option 1 I've pointed, unfortunately you'll receive the following error which I've currently fixed but waiting to be deployed:

There is no valid SKU with given worker server edition ("MemoryOptimized") and vCores (1).

Until then you may use Azure Portal to create the option 1, coordinatorServerEdition: BurstableMemoryOptimized with coordinatorVCores: 1.

@thomas11
Copy link
Author

thomas11 commented May 7, 2024

Ah, thank you. So there is a difference between our payload and the example, 1 vs 2 coordinatorVCores. Not easy to spot.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue points to a problem in the management-plane of the library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants